Skip to content

Commit

Permalink
LG-14497: LQA updates (#11305)
Browse files Browse the repository at this point in the history
* Translate "digit" as "chiffres" in French

* Add comma to Simplified Chinese translation

There was a comma missing from the voice message used to communicate address verification OTPs.

Note that the character here is a full width comma (U+FF0C).

* changelog: User-Facing Improvements, Identity verification, Updates to French and Simplified Chinese translations

* Remove telephony.format_type.digit from ALLOWED_UNTRANSLATED_KEYS
  • Loading branch information
matthinz authored and colter-nattrass committed Oct 23, 2024
1 parent 9751227 commit 232c27f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion config/locales/telephony/fr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ fr:
ten: dix
format_type:
character: caractères
digit: digit
digit: chiffres
personal_key_regeneration_notice: Une nouvelle clé personnelle a été émise pour votre compte %{app_name}. Si cela ne vient pas de vous, réinitialisez votre mot de passe.
personal_key_sign_in_notice: Votre clé personnelle vient d’être utilisée pour vous connecter à votre compte %{app_name}. Si cela ne vient pas de vous, réinitialisez votre mot de passe.
2 changes: 1 addition & 1 deletion config/locales/telephony/zh.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ zh:
%{app_name}: 你的一次性代码是 %{code}。此代码在 %{expiration} 分钟后作废。请勿与任何人分享此代码。
@%{domain} #%{code}
voice: 你好!你的%{format_length}%{format_type} %{app_name} 一次性代码是%{code}。你的一次性代码是 ,%{code}。重复一下,你的一次性代码是 %{code}。此代码 %{expiration} 分钟后会作废。
voice: 你好!你的%{format_length}%{format_type} %{app_name} 一次性代码是%{code}。你的一次性代码是 ,%{code}。重复一下,你的一次性代码是 %{code}。此代码 %{expiration} 分钟后会作废。
doc_auth_link: |-
%{app_name}: %{link} 你在验证身份以访问 %{sp_or_app_name}。拍张你身份证件的照片以继续。
error:
Expand Down
1 change: 0 additions & 1 deletion spec/i18n_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ class BaseTask
{ key: 'simple_form.no', locales: %i[es] }, # "No" is "No" in Spanish
{ key: 'telephony.format_length.six', locales: %i[zh] }, # numeral is not translated
{ key: 'telephony.format_length.ten', locales: %i[zh] }, # numeral is not translated
{ key: 'telephony.format_type.digit', locales: %i[fr] },
{ key: 'time.formats.event_date', locales: %i[es zh] },
{ key: 'time.formats.event_time', locales: %i[es zh] },
{ key: 'time.formats.event_timestamp', locales: %i[zh] },
Expand Down

0 comments on commit 232c27f

Please sign in to comment.