Use NewDeviceConcern consistently for session value #10678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Upcoming Features, Aggregated Sign-In Message, Fix aggregated new device sign-in for expired session
jmdembe
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates references to
user_session[:new_device]withNewDeviceConcern#new_device?.This is a refactoring following #10628 to consistently use the concern abstractions in place of direct references to the session.
One difference is that
new_device?will default totrueon an absent session value. In the real-world, this should never realistically happen when verifying 2FA after sign-in.📜 Testing Plan
Repeat Testing Plan from #9784