LG-13220: Fix aggregated new device sign-in for expired session #10628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
force-pushed
the
aduth-lg-13220-new-device-aggregated-timeout
branch
from
a0a5e60
to
825c964
Compare
changelog: Upcoming Features, Aggregated Sign-In Message, Fix aggregated new device sign-in for expired session
aduth
force-pushed
the
aduth-lg-13220-new-device-aggregated-timeout
branch
from
825c964
to
c1dae92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13220
🛠 Summary of changes
Fixes an issue where new-device email notification is not sent as expected when fully authenticating after letting a first sign-in attempt expire.
This feature is only enabled in local development, so this is not a bug affecting production.
📜 Testing Plan
Before: The second email is not sent after completing MFA.
After: Two emails are sent: One for the initial timeout of the notification window listing the email and password submission, and a second after completing MFA.