-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upkeep/php-reqs: Update PHP compat check to prevent fatal error #291
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
53592cf
Merge branch 'develop' of github.com:10up/simple-local-avatars into d…
Sidsector9 3de8e88
update php compat check to use 10up-lib/wp-compat-validation-tool
Sidsector9 6d0218c
update actions
Sidsector9 61e7be4
fix phpcs errors
Sidsector9 d40ef62
Merge branch 'develop' into upkeep/php-reqs
faisal-alvi 5ad7dd1
Merge branch 'upkeep/php-reqs' of github.com:10up/simple-local-avatar…
Sidsector9 6269560
fix failing test
Sidsector9 bbf74d7
fix action step label
Sidsector9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ bower_components | |
languages | ||
release | ||
vendor | ||
10up-lib | ||
composer.lock | ||
phpunit.xml | ||
.idea | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,63 @@ | ||
{ | ||
"name": "10up/simple-local-avatars", | ||
"description": "Adds an avatar upload field to user profiles. Generates requested sizes on demand just like Gravatar!", | ||
"type": "wordpress-plugin", | ||
"keywords": [ | ||
"wordpress", | ||
"10up" | ||
], | ||
"homepage": "https://github.com/10up/simple-local-avatars", | ||
"license": ["GPL-2.0-or-later"], | ||
"authors": [ | ||
{ | ||
"name": "10up", | ||
"homepage": "https://10up.com/" | ||
} | ||
], | ||
"support": { | ||
"issues": "https://github.com/10up/simple-local-avatars/issues", | ||
"source": "https://github.com/10up/simple-local-avatars" | ||
}, | ||
"require": { | ||
"php": ">=7.4" | ||
}, | ||
"require-dev": { | ||
"10up/phpcs-composer": "dev-master", | ||
"10up/wp_mock": "0.4.2", | ||
"yoast/phpunit-polyfills": "^1.0" | ||
}, | ||
"scripts": { | ||
"lint": [ | ||
"phpcs . --runtime-set testVersion 7.4-" | ||
], | ||
"lint-fix": [ | ||
"phpcbf ." | ||
], | ||
"phpcs:compat": "vendor/bin/phpcs simple-local-avatars.php includes --standard=PHPCompatibilityWP --extensions=php --runtime-set testVersion 7.4-" | ||
}, | ||
"minimum-stability": "dev", | ||
"config": { | ||
"allow-plugins": { | ||
"dealerdirect/phpcodesniffer-composer-installer": true | ||
} | ||
} | ||
"name": "10up/simple-local-avatars", | ||
"description": "Adds an avatar upload field to user profiles. Generates requested sizes on demand just like Gravatar!", | ||
"type": "wordpress-plugin", | ||
"keywords": [ | ||
"wordpress", | ||
"10up" | ||
], | ||
"homepage": "https://github.com/10up/simple-local-avatars", | ||
"license": ["GPL-2.0-or-later"], | ||
"authors": [ | ||
{ | ||
"name": "10up", | ||
"homepage": "https://10up.com/" | ||
} | ||
], | ||
"support": { | ||
"issues": "https://github.com/10up/simple-local-avatars/issues", | ||
"source": "https://github.com/10up/simple-local-avatars" | ||
}, | ||
"require": { | ||
"php": ">=7.4", | ||
"10up/wp-compat-validation-tool": "dev-trunk" | ||
}, | ||
"require-dev": { | ||
"10up/phpcs-composer": "dev-master", | ||
"10up/wp_mock": "0.4.2", | ||
"yoast/phpunit-polyfills": "^1.0" | ||
}, | ||
"scripts": { | ||
"lint": [ | ||
"phpcs . --runtime-set testVersion 7.4-" | ||
], | ||
"lint-fix": [ | ||
"phpcbf ." | ||
], | ||
"phpcs:compat": "vendor/bin/phpcs simple-local-avatars.php includes --standard=PHPCompatibilityWP --extensions=php --runtime-set testVersion 7.4-", | ||
"post-install-cmd": [ | ||
"./10up-lib/wp-compat-validation-tool/replace-namespace.sh SimpleLocalAvatarsValidator" | ||
], | ||
"post-update-cmd": [ | ||
"./10up-lib/wp-compat-validation-tool/replace-namespace.sh SimpleLocalAvatarsValidator" | ||
] | ||
}, | ||
"minimum-stability": "dev", | ||
"config": { | ||
"allow-plugins": { | ||
"dealerdirect/phpcodesniffer-composer-installer": true, | ||
"composer/installers": true | ||
} | ||
}, | ||
"repositories": [ | ||
{ | ||
"type": "git", | ||
"url": "https://github.com/10up/wp-compat-validation-tool.git" | ||
} | ||
], | ||
"extra": { | ||
"installer-paths": { | ||
"./{$name}/": ["10up/wp-compat-validation-tool"] | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason this was removed? they can be helpful when reviewing check runs that fail to see where things are going wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct, removed it mistakenly, fixed it in bbf74d7.