upkeep/php-reqs: Update PHP compat check to prevent fatal error #291
Conversation
jeffpaul
requested review from
a team and
faisal-alvi
and removed request for
dkotter,
jeffpaul and
a team
|
This solves it nicely in my testing. Thanks! |
There was a problem hiding this comment.
@Sidsector9 LGTM but Cypress and Linting workflows are failing, could you please check/address them?
|
@Sidsector9 still seeing Cypress/WP trunk check failing here, can you help look into resolving that? |
github-actions
bot
added
the
needs:refresh
github-actions
bot
removed
the
needs:refresh
…s into upkeep/php-reqs
|
@jeffpaul this is expected because the All tests are passing locally: 
|
| @@ -10,10 +10,10 @@ jobs: | |||
| name: Push to trunk | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Checkout code | |||
There was a problem hiding this comment.
any reason this was removed? they can be helpful when reviewing check runs that fail to see where things are going wrong
There was a problem hiding this comment.
You're correct, removed it mistakenly, fixed it in bbf74d7.
Description of the Change
Recently Publisher Media Kit reported a fatal issue caused due to redeclaration of a function across our 10up plugins.
Ref: 10up/publisher-media-kit#196
This PR fixes that by using 10up/wp-compat-validation-tool.
How to test the Change
Try running this PR on a PHP env lesser than the minimum supported version (7.4) and see the plugin gracefully exit with an error message in the admin screen.
Changelog Entry
Credits
Props @Sidsector9
Checklist: