Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PostCSS Preset Env #331

Merged
merged 15 commits into from
Jan 8, 2024
Merged

Conversation

Antonio-Laguna
Copy link
Member

@Antonio-Laguna Antonio-Laguna commented Oct 4, 2023

Related Issue/RFC: #326

Closes #326 #321

Description of the Change

Upgrade PostCSS to V9. I've also updated some dependencies to avoid security issues. I was getting 5 high severity vulnerabilities and now it's down to found 0 vulnerabilities. I think this also fixes the prettier issue for good.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: 1db80d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
10up-toolkit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Antonio-Laguna Antonio-Laguna marked this pull request as draft October 4, 2023 11:18
# Conflicts:
#	package-lock.json
#	packages/babel-preset-default/__tests__/__snapshots__/index.js.snap
#	packages/eslint-config/package.json
#	packages/toolkit/package.json
@Antonio-Laguna
Copy link
Member Author

@nicholasio I'm unsure what's going on here, failing on a test within /projects/library. I think this is due to NPM doing funky things with installation since nothing has changed there

@nicholasio
Copy link
Member

@Antonio-Laguna fixed, anything else that needs to be done here?

@nicholasio nicholasio marked this pull request as ready for review December 4, 2023 17:12
There are a few major changes in this release. While it probably won't break your build, it's worth noting everything that's changed.

* Node version required of 18 (previous LTS)
* Swapping `postcss-editor-styles` with `postcss-editor-styles-wrapper` which is compatible with PostCSS 8. This should be a seamless change as this is a fork of the original package that was updated to be compatible with PostCSS 8 and fixes wrong behaviour in some circumstances.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for those extending the postcss.config.js file so they will need to update it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@nicholasio
Copy link
Member

@Antonio-Laguna updated a few things, was there anything else here before we merge this?

@Antonio-Laguna
Copy link
Member Author

@nicholasio no, all good here! Thanks for giving it a final push. I was feeling stuck with this!

@nicholasio nicholasio merged commit 091bb26 into develop Jan 8, 2024
5 checks passed
@nicholasio nicholasio deleted the feature/upgrade-postcss-preset-env branch January 8, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update postcss-preset-env to v9
2 participants