Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint-config to @wordpress/eslint-plugin 14 #321

Closed
1 task done
orballo opened this issue Aug 10, 2023 · 3 comments
Closed
1 task done

Upgrade eslint-config to @wordpress/eslint-plugin 14 #321

orballo opened this issue Aug 10, 2023 · 3 comments
Labels
Dependencies Pull requests that update a dependency file [Type] Enhancement

Comments

@orballo
Copy link

orballo commented Aug 10, 2023

Is your enhancement related to a problem? Please describe.

npm install fails after upgrading @wordpress/eslint-plugin to v14.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @10up/eslint-config@3.1.1
npm ERR! Found: @wordpress/eslint-plugin@14.11.0
npm ERR! node_modules/@wordpress/eslint-plugin
npm ERR!   dev @wordpress/eslint-plugin@"^14.11.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional @wordpress/eslint-plugin@"^13.10.0" from @10up/eslint-config@3.1.1
npm ERR! node_modules/@10up/eslint-config
npm ERR!   peer @10up/eslint-config@"^3.1.1" from 10up-toolkit@5.2.2
npm ERR!   node_modules/10up-toolkit
npm ERR!     dev 10up-toolkit@"^5.2.2" from the root project
npm ERR!     1 more (10up-experience)
npm ERR!
npm ERR! Conflicting peer dependency: @wordpress/eslint-plugin@13.10.3
npm ERR! node_modules/@wordpress/eslint-plugin
npm ERR!   peerOptional @wordpress/eslint-plugin@"^13.10.0" from @10up/eslint-config@3.1.1
npm ERR!   node_modules/@10up/eslint-config
npm ERR!     peer @10up/eslint-config@"^3.1.1" from 10up-toolkit@5.2.2
npm ERR!     node_modules/10up-toolkit
npm ERR!       dev 10up-toolkit@"^5.2.2" from the root project
npm ERR!       1 more (10up-experience)
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@orballo
Copy link
Author

orballo commented Aug 10, 2023

Actually, this shouldn't fail because usually you don't need to install @wordpress/esling-plugin on your own.

@nicholasio
Copy link
Member

nicholasio commented Aug 10, 2023

In the latest version of toolkit you shouldn't need to update this (or include this manually). We'll bump this package in the next major.

@fabiankaegy fabiankaegy added the Dependencies Pull requests that update a dependency file label Nov 1, 2023
@nicholasio
Copy link
Member

Updated in #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants