Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test scroll #1574

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix test scroll #1574

merged 1 commit into from
Jun 5, 2023

Conversation

rvilarl
Copy link
Collaborator

@rvilarl rvilarl commented Jun 4, 2023

Hi Ron, please look into that, I had to undo some of your chenges in flow.html.

This PR avoids that the tests scroll behind the header.

@rvilarl rvilarl requested a review from ronyeh June 4, 2023 18:16
@ronyeh ronyeh merged commit 623d992 into 0xfe:master Jun 5, 2023
@ronyeh
Copy link
Collaborator

ronyeh commented Jun 5, 2023

There is still a small bug where the footer links are hidden behind the header, and one of the tests seems to be rendered off to the left. Can you investigate? We can perhaps merge the footer links into the header... since it is less likely someone will scroll all the way to the bottom of the huge page of tests.

Bug1

Additionally, I had added a short sentence saying "Please wait a moment while the tests run....", which your PR removed. I think it would be useful to have that in case the tests take a long time to run. On my machine, the webpage looks broken until the tests all finish:

    <h3>
        Please wait a moment while the tests run....<br /><br />
        See the: <a id="vex-src" target="_blank"></a>. Don't forget to run the
        <a href="https://github.com/0xfe/vexflow/wiki/Visual-Regression-Tests">Visual Regression Tests</a>!
    </h3>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants