Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test scroll #1574

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix test scroll #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/flow-headless-browser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="UTF-8" />
</head>
<body>
<div id="vexflow_testoutput"></div>
<div id="qunit-tests"></div>
<script src="../node_modules/qunit/qunit/qunit.js"></script>
<script src="../build/cjs/vexflow-debug-with-tests.js"></script>
<script>
Expand Down
20 changes: 9 additions & 11 deletions tests/flow.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,18 @@
<meta charset="UTF-8" />
</head>
<body>
<div style="text-align: center; margin-top: 180px">
<h2>[ <a href="https://vexflow.com">Home</a> ] [ <a href="https://github.com/0xfe/vexflow">GitHub</a> ]</h2>
<h3>
Please wait a moment while the tests run....<br /><br />
See the: <a id="vex-src" target="_blank"></a>. Don't forget to run the
<a href="https://github.com/0xfe/vexflow/wiki/Visual-Regression-Tests">Visual Regression Tests</a>!
</h3>
</div>
<div style="text-align: center">
<div id="qunit"></div>
<div id="qunit-fixture"></div>
<div id="vexflow_testoutput"></div>
</div>
<div style="text-align: center">
<div>
<h2>[ <a href="https://vexflow.com">Home</a> ] [ <a href="https://github.com/0xfe/vexflow">GitHub</a> ]</h2>
<h3>
See the: <a id="vex-src" target="_blank"></a>. Don't forget to run the
<a href="https://github.com/0xfe/vexflow/wiki/Visual-Regression-Tests">Visual Regression Tests</a>!
</h3>
</div>
<p>&nbsp;</p>
<p>&nbsp;</p>
<p class="vf-footer">
[ <a href="https://vexflow.com">Home</a> ] [ <a href="https://github.com/0xfe/vexflow">GitHub</a> ] [
<a href="https://muthanna.com/">0xfe</a> ]
Expand Down
2 changes: 1 addition & 1 deletion tests/vexflow_test_helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export class VexFlowTests {
const title = $('<div/>').addClass('name').attr('id', titleId).html(anchorTestTitle).get(0);
const vexOutput = $(`<${tagName}/>`).addClass('vex-tabdiv').attr('id', elementId).get(0);
const container = $('<div/>').addClass('testcanvas').append(title, vexOutput).get(0);
$('#vexflow_testoutput').append(container);
$('#qunit-tests').append(container);
return vexOutput;
}

Expand Down
2 changes: 1 addition & 1 deletion tools/generate_images_pptr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const launchTestPage = async (jobs, job) => {
});

const genImages = async () => {
const elmDefs = await page.$$eval('#vexflow_testoutput .testcanvas', (elms) => {
const elmDefs = await page.$$eval('#qunit-tests .testcanvas', (elms) => {
window.VF_TEST_GLOBAL = {};
const { VF_TEST_GLOBAL } = window;
const ret = [];
Expand Down
2 changes: 1 addition & 1 deletion tools/generate_png_images.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const { JSDOM } = require('jsdom');
const fs = require('fs');
const path = require('path');

const dom = new JSDOM(`<!DOCTYPE html><body><div id="vexflow_testoutput"></div></body>`);
const dom = new JSDOM(`<!DOCTYPE html><body><div id="qunit-tests"></div></body>`);
global.window = dom.window;
global.document = dom.window.document;

Expand Down