Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor encode funcs #1399

Merged
merged 11 commits into from
Jan 9, 2024
Merged

Refactor encode funcs #1399

merged 11 commits into from
Jan 9, 2024

Commits on Dec 21, 2023

  1. Refactor encode_empty_node and encode_branch_node 

    Clean code

Not important

Restore jumpdets_analysis.asm

Refactor encode_empty_node and encode_branch_node
    @4l0n50
    4l0n50 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    dfcf276 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Rebase to main 

    Refactor encode_empty_node and encode_branch_node

Add constant and store encoded empty node in an other position

Remove child segment

Clean code

Apply suggestions from code review

Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>

Remive global label

Move encoded empty nodes
    @4l0n50
    4l0n50 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    a834049 View commit details
    Browse the repository at this point in the history

  2. Remove duplicated label

    @4l0n50
    4l0n50 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    48b9769 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com>
Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
    @4l0n50 @LindaGuiga @Nashtare
    3 people authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    f4713c4 View commit details
    Browse the repository at this point in the history

  2. Address comments

    @4l0n50
    4l0n50 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    1c99473 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Adress reviewer comments

    @4l0n50
    4l0n50 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    77f5109 View commit details
    Browse the repository at this point in the history

  2. Minor

    @4l0n50
    4l0n50 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7fc6b86 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'public/main' into refactor_encode_funcs

    @4l0n50
    4l0n50 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    80917cb View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Address bundling

    @4l0n50
    4l0n50 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    22e267c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'public/main' into refactor_encode_funcs

    @4l0n50
    4l0n50 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3c699be View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @4l0n50
    4l0n50 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5b71eb4 View commit details
    Browse the repository at this point in the history