Refactor encode funcs #1399
Merged
Refactor encode funcs #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
added this to the v0.1.0-rc2 - Audit Fixes / Optimizations / Documentation milestone
Nashtare
reviewed
Dec 2, 2023
dvdplm
reviewed
Dec 18, 2023
Clean code Not important Restore jumpdets_analysis.asm Refactor encode_empty_node and encode_branch_node
hratoanina
reviewed
Dec 22, 2023
evm/src/cpu/kernel/interpreter.rs
Outdated
| @@ -942,6 +944,18 @@ impl<'a> Interpreter<'a> { | |||
| } | |||
| self.generation_state.registers.context = context; | |||
| } | |||
|
|
|||
| /// Writes the encoding of 0 to position @ | |||
There was a problem hiding this comment.
@ENCODED_EMPTY_NODE_POS?
Refactor encode_empty_node and encode_branch_node Add constant and store encoded empty node in an other position Remove child segment Clean code Apply suggestions from code review Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com> Remive global label Move encoded empty nodes
4l0n50
force-pushed
the
refactor_encode_funcs
branch
from
127c721
to
a834049
Compare
|
Sorry, I had to force push when I rebased to main |
LindaGuiga
approved these changes
Dec 28, 2023
Nashtare
reviewed
Jan 2, 2024
Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com> Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Nashtare
reviewed
Jan 8, 2024
Nashtare
approved these changes
Jan 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how branch and empty nodes are encoded:
It saves ~2500 cycles with add11_yml.