Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New assembly instructions #387

Merged
merged 2 commits into from
Sep 7, 2022
Merged

New assembly instructions #387

merged 2 commits into from
Sep 7, 2022

Conversation

OLUWAMUYIWA
Copy link
Contributor

What

Added assertz, u32wrapping_madd, and u32wrapping_add3 to assembly instructions.
Ref: #357

Also updated the documentation to accommodate the new insructions.

@OLUWAMUYIWA
Copy link
Contributor Author

@bobbinth please check.

bobbinth
bobbinth requested changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! I left a couple of very minor nit comments inline.

docs/src/user_docs/assembly/field_operations.md Show resolved Hide resolved
assembly/src/parsers/field_ops.rs Outdated Show resolved Hide resolved
assembly/src/parsers/u32_ops.rs Show resolved Hide resolved
@OLUWAMUYIWA
Copy link
Contributor Author

@bobbinth, I made the changes you requested

bobbinth
bobbinth approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you again!

@bobbinth bobbinth merged commit e658813 into 0xPolygonMiden:next Sep 7, 2022
@bobbinth bobbinth mentioned this pull request Sep 7, 2022
Closed
@bobbinth bobbinth mentioned this pull request Sep 16, 2022
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OLUWAMUYIWA @bobbinth