Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New assembly instruction #357

Closed
bobbinth opened this issue Aug 7, 2022 · 4 comments
Closed

New assembly instruction #357

bobbinth opened this issue Aug 7, 2022 · 4 comments
Assignees
@OLUWAMUYIWA
Labels
assembly Related to Miden assembly

Comments

@bobbinth
Copy link
Contributor

bobbinth commented Aug 7, 2022 •
edited
Loading

While going through the u64 module in stdlib, I noticed that some patterns of instructions are used frequently, and I'm wondering if it is worth implementing assembly instructions for them.

One such sequence is: eq.0 assert which asserts that the top of the stack is zero. An assembly instruction to do this could be called assertz.

Another such sequence is u32overflowing_madd drop which is just a wrapping version of this operation. An assembly instruction for this would be u32wrapping_madd. And for consistency, we should probably add u32wrapping_add3 as well.
@bobbinth bobbinth added assembly Related to Miden assembly v0.3 labels Aug 7, 2022
@OLUWAMUYIWA
Copy link
Contributor

Would love to work on this

@bobbinth
Copy link
Contributor Author

bobbinth commented Sep 4, 2022

@OLUWAMUYIWA - thank you for volunteering! It is all yours.

@OLUWAMUYIWA
Copy link
Contributor

Sure. On it. Thanks

@OLUWAMUYIWA OLUWAMUYIWA mentioned this issue Sep 6, 2022
Merged
@bobbinth
Copy link
Contributor Author

bobbinth commented Sep 7, 2022

Closed by #387

@bobbinth bobbinth closed this as completed Sep 7, 2022
@bobbinth bobbinth mentioned this issue Sep 7, 2022
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OLUWAMUYIWA OLUWAMUYIWA

Labels
assembly Related to Miden assembly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OLUWAMUYIWA @bobbinth