-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stdlib smt module for Word key/values #373
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgillett
changed the title
[DRAFT] Implement stdlib smt module for Word key/values
Implement stdlib smt module for Word key/values
Aug 23, 2022
Thank you! This looks great! A few comments about the general approach and structure (i.e., this is not an in-depth review).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses issue #258 by introducing the procedures
smt::get
,smt::update
andsmt::insert
in a newsmt
standard library module. These procedures allow manipulation of compacted sparse Merkle trees with Word-sized keys. The sparse Merkle tree advice set is modified to permit a compacted representation, where leaf values can be stored at depths that are smaller than the maximum depth of the tree.Integration tests are present for these three procedures, with some associated documentation describing the structure of the compact representation.
The following tasks remain to be implemented:
smt_insert_key
integration test documentation)get_path
test case error for non-compacted SMT advice set