Implement TSMT delete procedures #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Kindi-0
approved these changes
Aug 20, 2023
frisitano
reviewed
Aug 20, 2023
Comment on lines
582
to
583
| /// - KEY and VALUE is they key-value pair of a leaf node occupying the location of the node | ||
| /// for the specified key, if it was set in the TSMT. |
There was a problem hiding this comment.
If I understand correctly looking at:
- Leaf for another key: [d0, d1, ONE (is_leaf), ONE (key_not_set), KEY, VALUE]
then KEY, VALUE are they key and value of the leaf associated with a different key currently occupying the node. Should we document the fact it's a different KEY / VALUE pair?
There was a problem hiding this comment.
Agreed. I've kept the names the same but updated the description for KEY / VALUE pair.
frisitano
reviewed
Aug 21, 2023
|
Working as expected downstream for the asset vault in |
bobbinth
force-pushed
the
bobbin-tsmt-delete
branch
2 times, most recently
from
755f58c
to
767a961
Compare
bobbinth
force-pushed
the
bobbin-tsmt-delete
branch
from
767a961
to
bdc7109
Compare
Al-Kindi-0
approved these changes
Aug 29, 2023
This was referenced Aug 29, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements procedures to support insertion of empty values into TSMT. This also introduces
smt::setprocedure which can be used to insert either empty or non-empty values into the TSMT.As described in #1050, there is a soundness issue in the delete procedure. Since everything works as long as the advice provider behaves correctly, I've left this issue for a future PR.