Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed additional cli parameters from block-producer, store and RPC. #151

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

phklive
Copy link
Contributor

@phklive phklive commented Jan 16, 2024

In this PR I propose a removal of additional cli parameters from block-producer, store and RPC.

They were not in use for now and we were launching the node using config files, hence not needing them for now.

In the future we will think about how we want to handle the launch of the node.

closes: #124

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit c947270 into main Jan 16, 2024
4 checks passed
@bobbinth bobbinth deleted the phklive-remove-additional-cli-parameters branch January 16, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove additional CLI parameters
2 participants