Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional CLI parameters #124

Closed
bobbinth opened this issue Dec 24, 2023 · 3 comments · Fixed by #151
Closed

Remove additional CLI parameters #124

bobbinth opened this issue Dec 24, 2023 · 3 comments · Fixed by #151
Assignees
Labels
block-producer Related to the block producer component rpc Related to the RPC component store Related to the store component
Milestone

Comments

@bobbinth
Copy link
Contributor

CLI's of node components currently take a path to the config file and some additional parameters (e.g., host, port, sqlite for the store component). As far as I can tell, everything except for the config file, is currently ignored. So, we should remove these extra parameters as options.

@bobbinth bobbinth added store Related to the store component rpc Related to the RPC component block-producer Related to the block producer component labels Dec 24, 2023
@bobbinth
Copy link
Contributor Author

The other option is to make them work - see #75. But I'm not sure we need this.

@bobbinth bobbinth added this to the v0.2 milestone Jan 11, 2024
@hackaugusto
Copy link
Contributor

hackaugusto commented Jan 15, 2024

Without env variables and CLI options, it means that during deploying a configuration file needs to be generated, which adds a lot of complexity for smaller environments. Because not only you have to generate the files, you also have to manage them (as in, version, and location). env variables and cli allows one to deploy these systems without the extra overhead

@bobbinth
Copy link
Contributor Author

I think we still need to understand how we want the deployment process to work in the longer term. For example:

  • Do we go with separate binaries for each component (as we do now) or do we have a single binary and turn different components on/off via config params (as is described in #92?
  • Do we expect people to compile from source or use docker images or something else?

For now, I think it is simpler to remove CLI options (as they literally don't do anything), and once we have a better picture of how things will work, we can re-introduce what makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-producer Related to the block producer component rpc Related to the RPC component store Related to the store component
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants