Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): policy test temp dir creation #645

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix(test): policy test temp dir creation #645

merged 2 commits into from
Jun 19, 2024

Conversation

revitteth
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 19, 2024
@revitteth revitteth requested a review from cffls June 19, 2024 07:22
Copy link

sonarcloud bot commented Jun 19, 2024

Copy link

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@revitteth revitteth merged commit 2d2712a into zkevm Jun 19, 2024
5 checks passed
@revitteth revitteth deleted the fix/policy-test branch June 19, 2024 09:29
kstoykov pushed a commit that referenced this pull request Jun 19, 2024
* fix(test): policy test temp dir creation

* fix(test): increase timeout of test in makefile
revitteth added a commit that referenced this pull request Jun 20, 2024
* first steps in limbo - mainly handling unwinds as sequencer

do not return an error on bad execution during sequence execution
wip - do not merge these contents - testing only

fixups after rebase for limbo
do not commit this to zkevm - testing only!
ensure headers stage is updated during unwind
write the head header hash during unwind of inters
send bad block hash to unwind so that the stage loop completes

without this the pool is never notified of the unwind transactions
only apply limbo transactions to the limbo pool
changes to match in with the other work in the inters unwind
minor update to logging when entering limbo to make searching easier
ensure the pool has handled the unwind after bad execution before yielding transactions
making a start on the limbo api call - we need to handle this without GRPC concerns for ease at the moment
limbo endpoint added
some tweaks to limbo
some more fixes for limbo changes

fixups after rebase of limbo

* changing unwind to match zkevm for limbo

* Limbo 2 unwind (#413)

* update-execute-hashes

* update limbo-unwind

* add missing return

* fix-execution-unwind (#415)

* fix-execution-unwind

* remove debug

* fix concurrency issues in cancel all requests (#419)

* remove debug

* add verifier stage unwind description

* update executor logic (#424)

* update executor logic

* fix too many open db connections

* adding defer to promises

* update promises

* update promises + defer tx

* add comments

* remove sending batches to ds from execution

* remove commends, correct defer and use atomic.Bool

* add missing return params

* Limbo 2 tx pool (#492)

* tx-pool

* remove old artefacts

* processing unwound tx

* remove debug

* test limbo pool transactions for correctness

* remove useless function

* persist limbo

* limbo tests

* restore original version of addLocked

* merge from zkevm

* add blocks checks

* limbo verify

* update limbo persistency

* add limbo flag

* comment out debug info

* improve limbo - state changes + senders' counting

* update how sender add is read while persisting zk-limbo-pool

* fix state-root-mismatch

* restore accumulator changes + remove debug

* removed repeating block 1 to datastream

* monitor for deleted accounts in tx-pool

* finish current batch in case of an error adding tx

* feat(ci): implement 40 minute timeout for macos tests (#642)

* fix(test): policy test temp dir creation (#645)

* fix(test): policy test temp dir creation

* fix(test): increase timeout of test in makefile

---------

Co-authored-by: Kamen Stoykov <24619432+kstoykov@users.noreply.github.com>
Co-authored-by: Kamen Stoykov <k.stoykov@razorlabs.com>
Co-authored-by: Valentin Staykov <v.staykov@razorlabs.com>
Co-authored-by: Max Revitt <max.revitt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants