fix-execution-unwind #415
Merged
fix-execution-unwind #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hexoscott
approved these changes
May 14, 2024
revitteth
added a commit
that referenced
this pull request
Jun 20, 2024
* first steps in limbo - mainly handling unwinds as sequencer do not return an error on bad execution during sequence execution wip - do not merge these contents - testing only fixups after rebase for limbo do not commit this to zkevm - testing only! ensure headers stage is updated during unwind write the head header hash during unwind of inters send bad block hash to unwind so that the stage loop completes without this the pool is never notified of the unwind transactions only apply limbo transactions to the limbo pool changes to match in with the other work in the inters unwind minor update to logging when entering limbo to make searching easier ensure the pool has handled the unwind after bad execution before yielding transactions making a start on the limbo api call - we need to handle this without GRPC concerns for ease at the moment limbo endpoint added some tweaks to limbo some more fixes for limbo changes fixups after rebase of limbo * changing unwind to match zkevm for limbo * Limbo 2 unwind (#413) * update-execute-hashes * update limbo-unwind * add missing return * fix-execution-unwind (#415) * fix-execution-unwind * remove debug * fix concurrency issues in cancel all requests (#419) * remove debug * add verifier stage unwind description * update executor logic (#424) * update executor logic * fix too many open db connections * adding defer to promises * update promises * update promises + defer tx * add comments * remove sending batches to ds from execution * remove commends, correct defer and use atomic.Bool * add missing return params * Limbo 2 tx pool (#492) * tx-pool * remove old artefacts * processing unwound tx * remove debug * test limbo pool transactions for correctness * remove useless function * persist limbo * limbo tests * restore original version of addLocked * merge from zkevm * add blocks checks * limbo verify * update limbo persistency * add limbo flag * comment out debug info * improve limbo - state changes + senders' counting * update how sender add is read while persisting zk-limbo-pool * fix state-root-mismatch * restore accumulator changes + remove debug * removed repeating block 1 to datastream * monitor for deleted accounts in tx-pool * finish current batch in case of an error adding tx * feat(ci): implement 40 minute timeout for macos tests (#642) * fix(test): policy test temp dir creation (#645) * fix(test): policy test temp dir creation * fix(test): increase timeout of test in makefile --------- Co-authored-by: Kamen Stoykov <24619432+kstoykov@users.noreply.github.com> Co-authored-by: Kamen Stoykov <k.stoykov@razorlabs.com> Co-authored-by: Valentin Staykov <v.staykov@razorlabs.com> Co-authored-by: Max Revitt <max.revitt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.