Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotated sprites don't render properly when using 4:3 backgrounds / sprite cropping #72

Closed
drojf opened this issue Feb 1, 2022 · 2 comments
Closed

Rotated sprites don't render properly when using 4:3 backgrounds / sprite cropping #72

drojf opened this issue Feb 1, 2022 · 2 comments

Comments

@drojf
Copy link
Contributor

drojf commented Feb 1, 2022

In that scene where Rena is at an angle, the sprite is cut off, no matter the sprite option, no matter the text appearance option, if the 4:3/Original BG is used.
image
image

_Originally posted by @cam1170 in #133
@drojf drojf mentioned this issue Feb 1, 2022
Open
drojf added a commit that referenced this issue Jul 21, 2022
@drojf
Disable character rotation in 4:3 mode to avoid artifacting (#72)
2361daf 
 - Currently the method used to clip sprites to the 4:3 window doesn't work with rotation
 - As there are only 2 places across all the games where this issue happens, we just disable character rotation in those scenes rather than trying to fix it properly
 - This should only affect images from the `sprite` or `portrait` folder
@drojf
Copy link
Contributor Author

drojf commented Jul 21, 2022

I wasn't sure of the status of this - checking my computer I did make a fix for this but on a different branch.

I wrote the following for the commit:

Disable character rotation in 4:3 mode to avoid artifacting (#72)
- Currently the method used to clip sprites to the 4:3 window doesn't work with rotation
- As there are only 2 places across all the games where this issue happens, we just disable character rotation in those scenes rather than trying to fix it properly
- This should only affect images from the sprite or portrait folder

The "fix" just disables rotation in OG mode: 2361daf

I'm not sure why I didn't merge it into the mod.

@drojf drojf mentioned this issue Sep 18, 2022
Merged
drojf added a commit that referenced this issue Sep 18, 2022
@drojf
Disable character rotation in 4:3 mode to avoid artifacting (#72)
1de9dd1 
 - Currently the method used to clip sprites to the 4:3 window doesn't work with rotation
 - As there are only 2 places across all the games where this issue happens, we just disable character rotation in those scenes rather than trying to fix it properly
 - This should only affect images from the `sprite` or `portrait` folder
drojf added a commit that referenced this issue Sep 30, 2022
@drojf
Disable character rotation in 4:3 mode to avoid artifacting (#72)
7fbac57 
 - Currently the method used to clip sprites to the 4:3 window doesn't work with rotation
 - As there are only 2 places across all the games where this issue happens, we just disable character rotation in those scenes rather than trying to fix it properly
 - This should only affect images from the `sprite` or `portrait` folder
drojf added a commit that referenced this issue Sep 30, 2022
@drojf
Disable character rotation in 4:3 mode to avoid artifacting (#72)
fd31b00 
 - Currently the method used to clip sprites to the 4:3 window doesn't work with rotation
 - As there are only 2 places across all the games where this issue happens, we just disable character rotation in those scenes rather than trying to fix it properly
 - This should only affect images from the `sprite` or `portrait` folder
drojf added a commit that referenced this issue Sep 30, 2022
@drojf
Disable character rotation in 4:3 mode to avoid artifacting (#72)
7b1c27d 
 - Currently the method used to clip sprites to the 4:3 window doesn't work with rotation
 - As there are only 2 places across all the games where this issue happens, we just disable character rotation in those scenes rather than trying to fix it properly
 - This should only affect images from the `sprite` or `portrait` folder
@drojf
Copy link
Contributor Author

drojf commented Sep 30, 2022

This should now be fixed in all chapters except console arcs (there is no OG mode for console arcs anyway)

@drojf drojf closed this as completed Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drojf