Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backwards for loop instead of linq for performance in AttributeCollection.Remove #511

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Use backwards for loop instead of linq for performance in AttributeCollection.Remove #511

merged 1 commit into from
Aug 1, 2023

Conversation

campersau
Copy link
Contributor

@campersau campersau commented Jul 27, 2023 •
edited
Loading

Avoids List allocation and slower OrderByDescending.

@JonathanMagnan JonathanMagnan merged commit e581d69 into zzzprojects:master Aug 1, 2023
@JonathanMagnan JonathanMagnan self-assigned this Aug 1, 2023
@JonathanMagnan
Copy link
Member

Hello @campersau ,

Thank you for your contribution,

Your change has been merged and should be released later today.

Best Regards,

Jon

@JonathanMagnan
Copy link
Member

Hello @campersau ,

The v1.11.51 has been released.

Thank again for your contribution ;)

@campersau campersau deleted the perf1 branch August 1, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JonathanMagnan JonathanMagnan

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@campersau @JonathanMagnan