[Draft] refactor Entitize method, use HtmlEncode, add unit tests #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal with fix for #323
@JonathanMagnan hi there, can you please take a look at changes for Entitize method. I'm strongly suggesting use standard System.Net.WebUtility.HtmlEncode method for entitize unicode characters.
If it looks OK, I can improve DeEntitize method, just use System.Net.WebUtility.HtmlDecode method instead of complicated logic. Also I think it's really useful to get rid off _entityName, _entityValue dictionaries.
I'm aware of entitizeQuotAmpAndLtGt parameter and wasn't sure when we should ignore entitize these characters