Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Export to parquet instead of CSV #130

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

erfannariman
Copy link
Member

@erfannariman erfannariman commented Jun 4, 2024

closes #125

Not ideal that we have to convert datetime to str before exporting to parquet, but as far as I can tell, there's no other options because of the ADF conversion of datetime to int.

Copy link
Contributor

@TimvdHeijden TimvdHeijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran tests, checked specific for datetime and date type in the tables, this went correct.

@erfannariman erfannariman merged commit 1526908 into development Jun 5, 2024
2 checks passed
@erfannariman erfannariman deleted the 125-export-parquet branch June 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Export to parquet instead of .csv
2 participants