-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packages #107
Upgrade packages #107
Changes from 2 commits
85e2bdf
be58add
2bb5c77
e84e2c3
ca91da6
aac9748
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[metadata] | ||
name = df_to_azure | ||
version = 0.6.0 | ||
version = 0.6.1 | ||
author = Melvin Folkers, Erfan Nariman | ||
author_email = melvin@zypp.io, erfan@zypp.io | ||
description = Automatically create pipelines with copy activity from blob to SQL | ||
|
@@ -20,14 +20,14 @@ classifiers = | |
packages = df_to_azure | ||
python_requires = >=3.7 | ||
install_requires = | ||
azure-identity==1.6.0 | ||
azure-mgmt-datafactory==1.1.0 | ||
azure-mgmt-resource==19.0.0 | ||
azure-storage-blob==12.8.1 | ||
pandas==1.3.2 | ||
pyarrow==5.0.0 | ||
pyodbc==4.0.31 | ||
sqlalchemy==1.4.22 | ||
azure-identity==1.7.1 | ||
azure-mgmt-datafactory==2.2.0 | ||
azure-mgmt-resource==20.1.0 | ||
azure-storage-blob==12.9.0 | ||
pandas==1.4.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should align this with some other internal packages, since we will get difference in pandas versions between them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pandas version is equal to azure-batchload, do you seem any other problems? Because now the release candidate is not usable in combination with azure-batchload. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In what sense is not usable? I think the point is that if we upgrade the packages here, we should upgrade them in the other packages as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a mismatch in pandas dependencies, it might work, but it could be unexpected, not what you want. Which ones should be in scope for the 'other' packages (azure-batch-load matches with these changes), and why should we do that first (and not after we update df-to-azure in those packages)? |
||
pyarrow==7.0.0 | ||
pyodbc==4.0.32 | ||
sqlalchemy==1.4.31 | ||
|
||
|
||
[flake8] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to bump this to version 0.7.0. Since potentially there can be changes in functionality with upgrading the packages.