Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added llama3 prompt #1962

Merged
merged 5 commits into from
Jul 29, 2024
Merged

added llama3 prompt #1962

merged 5 commits into from
Jul 29, 2024

Conversation

hirschrobert
Copy link
Contributor

I was picking up issue #1889 , but had to change it a bit. meta documentation is here https://llama.meta.com/docs/model-cards-and-prompt-formats/meta-llama-3/.
Also some issues with double BOS tokens, so no BOS tokens here, see abetlen/llama-cpp-python#1439.

@hirschrobert
Copy link
Contributor Author

Hey @imartinez , is it possible to change the pull request rules so that workflows are run without approval. What is the reason for it? Without approval, tests can be run already and code improved by contributors beforehand so that merging by a maintainer should only be a formal issue. This should also speed up things. Many thanks!

@jaluma
Merge remote-tracking branch 'upstream/main' into llama3
6316317 
# Conflicts:
#	private_gpt/components/vector_store/vector_store_component.py
jaluma
jaluma requested changes Jul 5, 2024
View reviewed changes
private_gpt/components/llm/prompt_helper.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
private_gpt/components/llm/prompt_helper.py Show resolved Hide resolved
@jaluma
Copy link
Collaborator

jaluma commented Jul 5, 2024

Hey @imartinez , is it possible to change the pull request rules so that workflows are run without approval. What is the reason for it? Without approval, tests can be run already and code improved by contributors beforehand so that merging by a maintainer should only be a formal issue. This should also speed up things. Many thanks!

We have just changed how workflows are executed. Hopefully there won't be any more problems in the future :)

@jaluma
Copy link
Collaborator

jaluma commented Jul 29, 2024

Updated PR with requested changes!

imartinez
imartinez approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🦙

jaluma
jaluma approved these changes Jul 29, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
@jaluma jaluma merged commit d080969 into zylon-ai:main Jul 29, 2024
6 checks passed
@jordyantunes jordyantunes mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imartinez imartinez imartinez approved these changes

@jaluma jaluma jaluma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hirschrobert @jaluma @imartinez