-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): dockerfiles improvements and fixes #1792
Conversation
cab5238
to
9c9a09a
Compare
Hello All. Please clarify what command is better to use to build docker image locally, upload to GCP and use ? I do not see useful info in documentation related to docker creation |
@zylon-ai I keep on updating this branch, it would be nice to have a review at some point. Thanks 😉 |
I doubt anyone reads a markdown file within a Docker image
- For documentation purposes - Reflect defaults set in settings-docker.yml
* fix: ffmpy dependency * fix: block ffmpy to commit sha
* chore: update ollama (llm) * feat: allow to autopull ollama models * fix: mypy * chore: install always ollama client * refactor: check connection and pull ollama method to utils * docs: update ollama config with autopulling info ...
Published docs preview URL: https://privategpt-preview-4d7135ba-2e40-4816-8fa3-654844aaa338.docs.buildwithfern.com |
Updated this PR since it's really useful :) I've included:
|
Published docs preview URL: https://privategpt-preview-0b4b3e54-d4ea-42e4-ab4a-2794943cf525.docs.buildwithfern.com |
Thanks, sorry for the delay getting back at this PR! I'll rebase other branches I have based off this one soon, for more Docker-related improvements/ease-of-use. |
UID
andGID
build arguments forworker
user. This is useful to not have to change permissions on bind mounted directories.POETRY_EXTRAS
build argument with default values. Useful to re-build the image with some extras using--build-arg POETRY_EXTRAS="..."
Makefile
in Docker image so commands such asmake ingest
can be usedPYTHONPATH
value where path should be/home/worker/app/private_gpt
instead of/private_gpt
/home/worker
when creating user. This resolves a bunch of side dependencies warnings/problems.ENV
instructions together. Just a tiny bit faster to rebuild.PGPT_EMBEDDING_MODE
to define embedding mode. It's not always the same mode as the llm.python3 -m pipx ensurepath
(does not work and is fulfilled byENV PATH="/root/.local/bin:$PATH"
)&&
instead of;
to chain commands to detect failure betterNext PRs (after this one gets merged):
POETRY_EXTRAS
.