Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat dynamic time format based on video duration #59

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Feat dynamic time format based on video duration #59

merged 1 commit into from
Oct 21, 2024

Conversation

Xurdejl
Copy link

@Xurdejl Xurdejl commented Oct 21, 2024

I noticed the time display was always showing hours even for short videos (like 00:25:59 for a 25-minute video), which felt a bit cluttered and always bothered me. Most other players, like YouTube, only show hours when needed, so I thought we could do the same.

This pull request cherry-picks the commit I made in the other fork.

What's changed?

  • Short videos: 03:24 instead of 00:03:24
  • Long videos: still 01:23:45 (no change)
  • Everything else (milliseconds toggle, remaining time) works exactly the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants