feat: Brought use_cats and get_nterms into the scope of the python bindings #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved some discrepancies that arise among the scalars when applying simplification functions to a graph
mjsutcliffe99
changed the title
ABorgna
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Thanks!
Make sure to run a formatter on the code, and follow the other linter recommendations.
See: https://github.com/Quantomatic/quizx/blob/master/CONTRIBUTING.md#-coding-style
pybindings/quizx/scalar.py
Outdated
Comment on lines
15
to
19
| #d = json.loads(s.to_json()) | ||
| #d["power2"] *= 2 | ||
| #dStr = json.dumps(d) | ||
| #return PyzxScalar().from_json(dStr) | ||
| return PyzxScalar().from_json(s.to_json()) |
There was a problem hiding this comment.
Is this a leftover from debugging?
There was a problem hiding this comment.
Essentially, yes. The scalar doesn't seem to be accurate (largely, it seems, because not all of the scalar information gets encoded via json) - but this is an issue I'm yet to resolve (but will likely make a separate pull request for in due course). These remarked lines of code were just part of my trying to fix that.
ABorgna
changed the title
Trying to include use_cats here seemed to cause formatting issues which would not resolve, but it doesn't seem necessary to include it here anyway
|
I added a couple fixes to pass the checks ran by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought use_cats and get_nterms into the scope of the python bindings (such that these can now be changed/read within Python when using the bindings).
Moreover, the Python bindings for simplifying graphs did not work, but a couple of trivial changes seem to fix it.