fix: code styling issues mentioned in the previous PR openedx#1177

zwidekalanga · Apr 11, 2024 · 97827f2 · 97827f2
1 parent 220f4fa
commit 97827f2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/components/Admin/index.jsx b/src/components/Admin/index.jsx
@@ -309,12 +309,10 @@ class Admin extends React.Component {
           <>
             <Helmet title="Learner Progress Report" />
             <Hero title="Learner Progress Report" />
-            <div className="mt-4">
-              <BudgetExpiryAlertAndModal />
-            </div>
             <div className="container-fluid">
               <div className="row mt-4">
                 <div className="col">
+                  <BudgetExpiryAlertAndModal />
                   <h2>Overview</h2>
                 </div>
               </div>

diff --git a/src/components/BudgetExpiryAlertAndModal/data/utils.js b/src/components/BudgetExpiryAlertAndModal/data/utils.js
@@ -13,7 +13,7 @@ export const getExpirationMetadata = (endDateStr) => {
   const thresholdKeys = Object.keys(ExpiryThresholds).sort((a, b) => a - b);
   const thresholdKey = thresholdKeys.find((key) => durationDiff.asDays() <= key);
 
-  if (thresholdKey === undefined) {
+  if (!thresholdKey) {
     return {
       thresholdKey: null,
       threshold: null,
@@ -34,7 +34,7 @@ export const getExpirationMetadata = (endDateStr) => {
 export const isPlanApproachingExpiry = (endDateStr) => {
   const { thresholdKey, threshold } = getExpirationMetadata(endDateStr);
 
-  if (thresholdKey === null) {
+  if (!thresholdKey) {
     return false;
   }