Priority route not visible with "star" #3492

Beer17HWAM · 2023-12-20T09:56:33Z

My friend and I both have the same zwave-js-ui 9.3.2 version. I can see all the Priority routes, visible with "star" in the network graph. My friend isn't seeing any "star".

How is that posible?

robertsLando · 2023-12-20T10:35:58Z

But did you set that priority route manually or what?
Firstly switch to latest 9.6.0

Beer17HWAM · 2023-12-20T10:52:19Z

Yes we both added routes manually. We did mainly the same things. Just add some priority routes. I use those to have a more stable situation. Since I use priority routes it works better. My friend want those too but isn't seeing any "stars". I know that there are newer versions but my friend hasn't got any "stars" for months now. And I do. The only difference is I run a separate docker and my friend has the hassio addon. Very strange, we use the same version and the same hardware zwave dongle.

robertsLando · 2023-12-20T14:15:11Z

This explanation alone doesn't give me enough context to tell you what's going on there, what I can think is that for some reason he did a route update and the priority route has been removed and it became a LWR route instead

Beer17HWAM · 2023-12-20T14:18:37Z

No, the priority route isn't removed. It's still there. But I see all small "stars" in the network graph view but in his network graph no starts are visible.

robertsLando · 2023-12-20T14:20:35Z

I dunno, if your friend has such issue he should upload nodes json so I can give it a look

Beer17HWAM · 2023-12-20T17:29:51Z

nodes_dump.json
This is his json export.

robertsLando · 2023-12-21T07:43:36Z

The only one with an application route set is node 22 and it has:

"lwr": {
        "protocolDataRate": 2,
        "repeaters": [
          3
        ]
 },
"nlwr": {
        "protocolDataRate": 3,
        "repeaters": [],
        "rssi": -54,
        "repeaterRSSI": []
},
"applicationRoute": {
      "repeaters": [],
      "routeSpeed": 3
    },

Does he see the star on the link from 22 to the controller? I have a feel if he doesn't it could be because the nlwr mathes the application route

Beer17HWAM · 2023-12-21T08:02:03Z

He doesn't see any star, no stars at all. And when he sets more priority routes they don't stick. After he sets a priority route and leave the popup and click the node again the priority route is gone. Only on node 22 it stays. Setting priority routes is not going well and he doesn't see any star.

Nodes with priority:
Node 3, 5, 32, 46, 31, 45, 22 (also return)

robertsLando · 2023-12-21T09:40:00Z

I need driver logs that show the tries of setting a priority route

jeroen84s · 2023-12-21T10:39:23Z

zwave-js-ui-store.zip
Are those the correct log file? If not, can you explain how to create the driver logs?

robertsLando · 2023-12-21T11:01:16Z

Them are correct. Thanks. I need to ask @AlCalzone to review them. Anywat could you also try to upgrade to latest ? 9.6.0?

robertsLando · 2023-12-21T11:03:10Z

I only see a successfull try in logs and no fail:

2023-12-21T10:31:23.954Z DRIVER » [REQ] [SetPriorityRoute]
                                    node ID:     24
                                    repeaters:   none
                                    route speed: 100k
2023-12-21T10:31:23.957Z SERIAL « [ACK]                                                                   (0x06)
2023-12-21T10:31:23.964Z SERIAL « 0x01050193180171                                                     (7 bytes)
2023-12-21T10:31:23.966Z SERIAL » [ACK]                                                                   (0x06)
2023-12-21T10:31:23.970Z DRIVER « [RES] [SetPriorityRoute]
                                    success: true
2023-12-21T10:31:23.975Z CNTRLR   Retrieving priority route to node 24...
2023-12-21T10:31:23.981Z SERIAL » 0x010400921871                                                       (6 bytes)
2023-12-21T10:31:23.983Z DRIVER » [REQ] [GetPriorityRoute]
                                    node ID: 24
2023-12-21T10:31:23.986Z SERIAL « [ACK]                                                                   (0x06)
2023-12-21T10:31:23.988Z SERIAL « 0x010a0192181000000000036d                                          (12 bytes)
2023-12-21T10:31:23.990Z SERIAL » [ACK]                                                                   (0x06)
2023-12-21T10:31:23.992Z DRIVER « [RES] [GetPriorityRoute]
                                    node ID:     24
                                    route kind:  Application
                                    repeaters:   none
                                    route speed: 100k

jeroen84s · 2023-12-21T11:06:40Z

I can't update to a newer version, because I use hassio addon

Beer17HWAM · 2023-12-21T11:10:48Z

Again, in my opinion it has nothing to do with the version because I use the same version in a docker. I see beautiful "stars". :-)

AlCalzone · 2023-12-21T11:56:52Z

@robertsLando how are the stars drawn? Are they text/emojis or SVG?

Can we somehow confirm whether Z-UI sees the routes as priority routes? In other words, can we confirm whether this is a pure display issue?

Beer17HWAM · 2023-12-21T11:59:37Z

See jpg. This is mine. The network graph of @jeroen84s isn't displaying any "star".

Beer17HWAM · 2023-12-21T12:02:16Z

@robertsLando how are the stars drawn? Are they text/emojis or SVG?

Can we somehow confirm whether Z-UI sees the routes as priority routes? In other words, can we confirm whether this is a pure display issue?

It's not only a display issue. The priority routes @jeroen84s is making are not saved. He can set a route (and back) but after closing the node and opening the node the priority route is gone.

AlCalzone · 2023-12-21T12:27:04Z

Ok I'll try to look at the logs tonight. Maybe I'll see something.

robertsLando · 2023-12-21T13:08:39Z

@AlCalzone them are SVG and as said I don't see any error in the logs he uploaded above. Anyway IMO this seems to me a display issue but I may be wrong

Beer17HWAM · 2023-12-21T13:12:19Z

Not only a display issue!! I already said:
The priority routes @jeroen84s is making are not saved. He can set a route (and back) but after closing the node and opening the node the priority route is gone.

AlCalzone · 2023-12-22T12:36:09Z

@jeroen84s is showing that several communication attempts succeed using the priority routes, e.g.

2023-12-21T10:30:05.168Z DRIVER « [REQ] [SendData]
                                    callback id:            1
                                    transmit status:        OK, took 90 ms
                                    routing attempts:       3
                                    protocol & route speed: Z-Wave, 40 kbit/s
                                    routing scheme:         Priority Route
                                    ACK RSSI:               -68 dBm
                                    ACK channel no.:        1
                                    TX channel no.:         1

and that several priority routes are known, e.g.:

2023-12-21T10:30:07.275Z DRIVER « [RES] [GetPriorityRoute]
                                    node ID:     46
                                    route kind:  Application
                                    repeaters:   5
                                    route speed: 100k

Also, assigning the routes works too:

2023-12-21T10:31:23.940Z CNTRLR   Setting priority route to node 24...
2023-12-21T10:31:23.944Z DRIVER   all queues busy
2023-12-21T10:31:23.952Z SERIAL » 0x010900931800000000037e                                            (11 bytes)
2023-12-21T10:31:23.954Z DRIVER » [REQ] [SetPriorityRoute]
                                    node ID:     24
                                    repeaters:   none
                                    route speed: 100k
2023-12-21T10:31:23.957Z SERIAL « [ACK]                                                                   (0x06)
2023-12-21T10:31:23.964Z SERIAL « 0x01050193180171                                                     (7 bytes)
2023-12-21T10:31:23.966Z SERIAL » [ACK]                                                                   (0x06)
2023-12-21T10:31:23.970Z DRIVER « [RES] [SetPriorityRoute]
                                    success: true
2023-12-21T10:31:23.975Z CNTRLR   Retrieving priority route to node 24...
2023-12-21T10:31:23.981Z SERIAL » 0x010400921871                                                       (6 bytes)
2023-12-21T10:31:23.983Z DRIVER » [REQ] [GetPriorityRoute]
                                    node ID: 24
2023-12-21T10:31:23.986Z SERIAL « [ACK]                                                                   (0x06)
2023-12-21T10:31:23.988Z SERIAL « 0x010a0192181000000000036d                                          (12 bytes)
2023-12-21T10:31:23.990Z SERIAL » [ACK]                                                                   (0x06)
2023-12-21T10:31:23.992Z DRIVER « [RES] [GetPriorityRoute]
                                    node ID:     24
                                    route kind:  Application
                                    repeaters:   none
                                    route speed: 100k

What might be happening: This node is a sleeping node, so there are no route statistics yet to draw the route. I think Z-UI isn't handling the case where there are no statistics, but the priority route is known. @robertsLando

Beer17HWAM · 2023-12-22T12:41:57Z

@AlCalzone Can you see the routes back also? The route back isn't shown in the Node when you open it again in the Network Graph after setting it. And why do I see "stars" and @jeroen84s not? I think it's all very strange. Why this complete other reaction than I have. I also set priority routes with sleeping Nodes. Also setting prio routes between Nodes with power (non sleeping Nodes) isn't displaying any "star". Am I the only one with visible "stars"? Lucky guy I am. ;-)

AlCalzone · 2023-12-22T13:31:50Z

The routes back require communication with the node, which doesn't happen when the node is asleep. It has to be woken up for the return route to actually be saved.
After that there has been communication with the node, which means there are routing statistics, which means this display bug in Z-Wave JS UI probably won't trigger anymore for that node.

As for routes to and from powered nodes: I need to see a log of that.

jeroen84s · 2023-12-22T16:01:56Z

Your vision about the sleeping nodes looks correct. Both wall plugs has a priority route (also return route). And the star in is not showing up in the graphic

Beer17HWAM · 2023-12-22T16:04:40Z

Your vision about the sleeping nodes looks correct. Both wall plugs has a priority route (also return route). And the star in is not showing up in the graphic

No stars. Maybe with Christmas. Just wait. ;-)

nmpu · 2024-01-23T07:42:54Z

I've never seen stars either. I saw the legend, but never knew what I was missing. My priority routes are still there when I drill down and the diagram has changed-- just no stars. All my priority routes involve powered devices. This is one of those features that is probably rarely used or missed. BTW, the 'Node properties' popup gets clipped by Daniel's donation footer. The [Ping] button is obscured.

robertsLando · 2024-01-23T07:54:02Z

@nmpu can't you just drag the dialog a bit higher? it can be moved where you want

nmpu · 2024-01-23T08:16:45Z

@robertsLando yes, that does work. I'm not used to web dialogs being moveable. Pretty fancy. Once you know there's a [Ping] button, you can blindly click on the top edge.

Should I also see stars in the app? I don't.

The 'Show return routes' and 'Show priority routes' checkboxes get disabled in the global view, but are enabled in the node view. However, the previous state remains when grayed. Is that how it's supposed to work?

Beer17HWAM · 2024-01-23T14:52:49Z

The https://github.com/zwave-js/zwave-js-ui version has a star:

robertsLando · 2024-01-23T14:58:43Z

star should be in dist/star.svg and that dist folder is only created during the build step. I think it is there but for some reason the addon proxy doens't serve it correctly

github-actions · 2024-04-23T00:31:14Z

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

Beer17HWAM · 2024-04-23T05:54:42Z

It's still not fixed in the latest release. Please fix.

robertsLando · 2024-04-23T13:34:20Z

I sincerly have no clue how to fix this as it's working on all my instances

Beer17HWAM · 2024-04-23T14:10:31Z

The star.svg is not available in his environment. How can he fix this?

robertsLando · 2024-04-23T15:59:07Z

I cannot help so much as the error seems to be on addon side, only @frenck could help here and I already tagged him

github-actions · 2024-07-23T00:35:31Z

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

Beer17HWAM · 2024-07-23T06:04:10Z

Please help us with this problem. @frenck isn't available???

AlCalzone · 2024-07-23T12:18:25Z

https://github.com/hassio-addons/addon-zwave-js-ui/issues

Beer17HWAM · 2024-07-23T14:23:48Z

I give up. My separate zwave docker is working fine. I see stars. My friend doesn't have stars in his HA zwave addon. If the developers of zwave and the HA addon are not able to fix it, I give up.
See hassio-addons/addon-zwave-js-ui#692

TheDK · 2024-07-23T14:45:12Z

@frenck says:

The file is simply not available!!

Correct, as the path is not right. The X-External-Path isn't honored by upstream. That is not an add-on issue.

../Frenck

I can confirm that it does not work when packaged as the HA Add-on.

robertsLando · 2024-07-23T15:00:44Z

The star svg path is passed in this way:

zwave-js-ui/src/components/custom/ZwaveGraph.vue

Line 379 in 37dfcd3

starSvg: '/star.svg',

Same for the logo you see in top left corner:

zwave-js-ui/src/App.vue

Line 18 in 37dfcd3

src="/logo.svg"

The logo is working and the star is not.

So sincerly I dunno why the star request doesn't respect the X-External-Path. It could be that for some reason vis-network is loading it in a wrong way?

AlCalzone · 2024-07-23T15:12:16Z

Looks like vis-network is doing the request itself. Can you filter/redirect it using the service worker maybe?

hugo-leij · 2024-07-23T19:15:08Z

it will be great if we can see the stars :-)

Beer17HWAM · 2024-07-23T19:18:18Z

I guess nobody is going to fix this for the HA addin users. Just run zwave separate in a docker and you can see beautiful stars. :-)

robertsLando · 2024-07-24T07:05:35Z

@AlCalzone I was looking at vis-network code, wondering if using https://github.com/visjs/vis-network/blob/master/lib/network/CachedImage.js#L7 cold work. Let me try

robertsLando · 2024-07-24T07:11:27Z

Works 🎉

Beer17HWAM · 2024-08-06T13:52:50Z

Works!!! Thanks!!

hugo-leij · 2024-08-06T15:29:34Z

Nice! i'm still waiting for an update via hassio add-on

Beer17HWAM · 2024-08-06T15:36:44Z

Hassio Addin Version 3.9.3 is available.

…

On Tue, 6 Aug 2024, 17:29 hugo-leij, ***@***.***> wrote: Nice! i'm still waiting for an update via hassio add-on — Reply to this email directly, view it on GitHub <#3492 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXIR3XBO7ZTHNJAXQPLHUULZQDTXJAVCNFSM6AAAAABA4RGZIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRGU3TGOBSHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

hugo-leij · 2024-08-06T15:43:27Z

I see! uhm, the update is not (yet) available via home assistant. Hopefully, tomorrow

hugo-leij · 2024-08-06T22:09:09Z

Yea!

Beer17HWAM added the question Further information is requested label Dec 20, 2023

Beer17HWAM assigned robertsLando Dec 20, 2023

github-actions bot added the Stale label Apr 23, 2024

github-actions bot removed the Stale label Apr 24, 2024

github-actions bot added the Stale label Jul 23, 2024

Beer17HWAM mentioned this issue Jul 23, 2024

Priority route not visible with "star" hassio-addons/addon-zwave-js-ui#692

Closed

github-actions bot removed the Stale label Jul 24, 2024

robertsLando closed this as completed in 2ffc1e5 Jul 24, 2024

Priority route not visible with "star" #3492

Priority route not visible with "star" #3492

Comments

Beer17HWAM commented Dec 20, 2023

robertsLando commented Dec 20, 2023

Beer17HWAM commented Dec 20, 2023 • edited Loading

robertsLando commented Dec 20, 2023

Beer17HWAM commented Dec 20, 2023

robertsLando commented Dec 20, 2023

Beer17HWAM commented Dec 20, 2023

robertsLando commented Dec 21, 2023

Beer17HWAM commented Dec 21, 2023 • edited Loading

robertsLando commented Dec 21, 2023

jeroen84s commented Dec 21, 2023

robertsLando commented Dec 21, 2023

robertsLando commented Dec 21, 2023

jeroen84s commented Dec 21, 2023

Beer17HWAM commented Dec 21, 2023

AlCalzone commented Dec 21, 2023 • edited Loading

Beer17HWAM commented Dec 21, 2023 • edited Loading

Beer17HWAM commented Dec 21, 2023

AlCalzone commented Dec 21, 2023

robertsLando commented Dec 21, 2023

Beer17HWAM commented Dec 21, 2023

AlCalzone commented Dec 22, 2023

Beer17HWAM commented Dec 22, 2023 • edited Loading

AlCalzone commented Dec 22, 2023

jeroen84s commented Dec 22, 2023

Beer17HWAM commented Dec 22, 2023

nmpu commented Jan 23, 2024

robertsLando commented Jan 23, 2024

nmpu commented Jan 23, 2024

Beer17HWAM commented Jan 23, 2024

robertsLando commented Jan 23, 2024 • edited Loading

github-actions bot commented Apr 23, 2024

Beer17HWAM commented Apr 23, 2024

robertsLando commented Apr 23, 2024

Beer17HWAM commented Apr 23, 2024

robertsLando commented Apr 23, 2024

github-actions bot commented Jul 23, 2024

Beer17HWAM commented Jul 23, 2024

AlCalzone commented Jul 23, 2024

Beer17HWAM commented Jul 23, 2024 • edited Loading

TheDK commented Jul 23, 2024

robertsLando commented Jul 23, 2024 • edited Loading

AlCalzone commented Jul 23, 2024

hugo-leij commented Jul 23, 2024

Beer17HWAM commented Jul 23, 2024

robertsLando commented Jul 24, 2024

robertsLando commented Jul 24, 2024

Beer17HWAM commented Aug 6, 2024

hugo-leij commented Aug 6, 2024

Beer17HWAM commented Aug 6, 2024 via email

hugo-leij commented Aug 6, 2024

hugo-leij commented Aug 6, 2024

Beer17HWAM commented Dec 20, 2023 •

edited

Loading

Beer17HWAM commented Dec 21, 2023 •

edited

Loading

AlCalzone commented Dec 21, 2023 •

edited

Loading

Beer17HWAM commented Dec 21, 2023 •

edited

Loading

Beer17HWAM commented Dec 22, 2023 •

edited

Loading

robertsLando commented Jan 23, 2024 •

edited

Loading

Beer17HWAM commented Jul 23, 2024 •

edited

Loading

robertsLando commented Jul 23, 2024 •

edited

Loading