Skip to content

Commit

Permalink
fix(ui): add support for step on value ids inputs
Browse files Browse the repository at this point in the history 
Ref zwave-js/node-zwave-js#7348
  • Loading branch information
@robertsLando
robertsLando committed Nov 4, 2024
1 parent 47f4c89 commit 1107718
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/components/ValueId.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
:append-outer-icon="!disable_send ? 'send' : null"
:suffix="value.unit"
:min="value.min != value.max ? value.min : null"
:step="1"
:step="value.step || 1"
persistent-hint
:max="value.min != value.max ? value.max : null"
:hint="help"
Expand All @@ -79,7 +79,7 @@
<v-text-field
:type="value.type === 'number' ? 'number' : 'text'"
:min="value.min != value.max ? value.min : null"
:step="1"
:step="value.step || 1"
persistent-hint
:readonly="disable_send"
:max="value.min != value.max ? value.max : null"
Expand Down

2 comments on commit 1107718

@AlCalzone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property is called steps with an s:
Image

@robertsLando
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but I call it step when parsing valueIds:

zwave-js-ui/api/lib/ZwaveClient.ts

Line 6217 in 1107718

valueId.step = (zwaveValueMeta as ValueMetadataNumeric).steps

Please sign in to comment.