fix(config): remove param #5 from ZW130

zwave-js · Sep 15, 2020 · ba51f8b · ba51f8b
1 parent e6c3fa1
commit ba51f8b
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 196 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@
 -->
 
 ## __WORK IN PROGRESS__
+### Config changes
+* Removed parameter #5 from `Aeon Labs ZW130` because it doesn't seem to be supported in any firmware version
+
 ### Bugfixes
 * A node is no longer marked as dead or asleep if it fails to respond to a `Configuration CC::Get` request. This can happen if the parameter is not supported.
 

diff --git a/...nfig/config/devices/0x0086/zw130_1.6.json → ...s/config/config/devices/0x0086/zw130.json b/...nfig/config/devices/0x0086/zw130_1.6.json → ...s/config/config/devices/0x0086/zw130.json
@@ -21,7 +21,7 @@
 		}
 	],
 	"firmwareVersion": {
-		"min": "1.6",
+		"min": "0.0",
 		"max": "255.255"
 	},
 	"supportsZWavePlus": true,
@@ -110,20 +110,21 @@
 				}
 			]
 		},
-		"5": {
-			// It is not clear when this config parameter was added
-			// My device with v1.5 did not have it, so I'm assuming 1.6
-			"label": "Color",
-			"description": "Configure which color will be displayed when a button is pressed",
-			"valueSize": 4,
-			"minValue": 0,
-			"maxValue": 4294967040,
-			"defaultValue": 65280,
-			"unsigned": true,
-			"readOnly": false,
-			"writeOnly": false,
-			"allowManualEntry": true
-		},
+		// It is not clear when this config parameter was added
+		// My device with did not have it in v1.5 and v1.8, which is currently the latest version
+		// It is also not present in v2.3 (new hardware revision)
+		// 	"5": {
+		// 	"label": "Color",
+		// 	"description": "Configure which color will be displayed when a button is pressed",
+		// 	"valueSize": 4,
+		// 	"minValue": 0,
+		// 	"maxValue": 4294967040,
+		// 	"defaultValue": 65280,
+		// 	"unsigned": true,
+		// 	"readOnly": false,
+		// 	"writeOnly": false,
+		// 	"allowManualEntry": true
+		// },
 		"39": {
 			"label": "Low battery value",
 			"description": "Set the low battery value",

diff --git a/packages/config/config/devices/0x0086/zw130_0.0-1.5.json b/packages/config/config/devices/0x0086/zw130_0.0-1.5.json
diff --git a/packages/config/config/devices/index.json b/packages/config/config/devices/index.json
@@ -4786,59 +4786,29 @@
         "productId": "0x0082",
         "firmwareVersion": {
             "min": "0.0",
-            "max": "1.5"
-        },
-        "filename": "0x0086/zw130_0.0-1.5.json"
-    },
-    {
-        "manufacturerId": "0x0086",
-        "productType": "0x0102",
-        "productId": "0x0082",
-        "firmwareVersion": {
-            "min": "0.0",
-            "max": "1.5"
-        },
-        "filename": "0x0086/zw130_0.0-1.5.json"
-    },
-    {
-        "manufacturerId": "0x0086",
-        "productType": "0x0202",
-        "productId": "0x0082",
-        "firmwareVersion": {
-            "min": "0.0",
-            "max": "1.5"
-        },
-        "filename": "0x0086/zw130_0.0-1.5.json"
-    },
-    {
-        "manufacturerId": "0x0086",
-        "productType": "0x0002",
-        "productId": "0x0082",
-        "firmwareVersion": {
-            "min": "1.6",
             "max": "255.255"
         },
-        "filename": "0x0086/zw130_1.6.json"
+        "filename": "0x0086/zw130.json"
     },
     {
         "manufacturerId": "0x0086",
         "productType": "0x0102",
         "productId": "0x0082",
         "firmwareVersion": {
-            "min": "1.6",
+            "min": "0.0",
             "max": "255.255"
         },
-        "filename": "0x0086/zw130_1.6.json"
+        "filename": "0x0086/zw130.json"
     },
     {
         "manufacturerId": "0x0086",
         "productType": "0x0202",
         "productId": "0x0082",
         "firmwareVersion": {
-            "min": "1.6",
+            "min": "0.0",
             "max": "255.255"
         },
-        "filename": "0x0086/zw130_1.6.json"
+        "filename": "0x0086/zw130.json"
     },
     {
         "manufacturerId": "0x0086",