Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Android 6 Marshmallow support #5114

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Nov 9, 2021

Much like in #4938 for the previous bump.

As discussed in chat:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1278266

and following discussion at #4842 (comment) .

Much as in 2e7ea83, and b3eced0 before that.

This change will also permit a few simplifications in the existing
code, but we leave those for separate followup commits.
We've just bumped our minimum Android and therefore minimum Chrome
version, and it has both of these.  So does our minimum Safari version;
the comment on one says "at least Safari 13", but consulting MDN:
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from#browser_compatibility

says it's been there since Safari on iOS 9.

And with that following fc0add5, we have no polyfills left!
That might not always be true in the future, but it's nice to
have it true for now.
We've just bumped our minimum version to API 24, aka Android 7 N.
@chrisbobbe chrisbobbe merged commit fb78ddd into zulip:main Nov 9, 2021
@chrisbobbe
Copy link
Contributor

Thanks, LGTM! Merged.

@gnprice gnprice deleted the pr-drop-android-6 branch November 9, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants