ServerCompatBanner: Bump minSupportedVersion to 2.1.0, as planned.
#4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't gotten negative feedback about the banner from the smaller pool of users connecting to servers earlier than 2.0.0. The banner was introduced with that threshold (in PR zulip#4750) to beta users in v27.164 (2021-06-17) and to all users in v27.165 (2021-06-24). So, proceed with aligning our threshold with what we declare in the server stable-release doc, and update the code comment to match.
|
Thanks for following up on this! Looks good -- merging. Here's the helpful details from your commit message on why it's time for this, just so they're more visible here:
|
gnprice
force-pushed
the
pr-bump-min-supported-version
branch
from
7aadde6 to
37074ce
Compare
|
Thanks for the review and for copying over those details! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.