Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headings jitter on scroll through unreads or users list #3176

Closed
jainkuniya opened this issue Nov 29, 2018 · 3 comments
Closed

Headings jitter on scroll through unreads or users list #3176

jainkuniya opened this issue Nov 29, 2018 · 3 comments
Labels
upstream: RN Issues related to an issue in React Native

Comments

@jainkuniya
Copy link
Member

jainkuniya commented Nov 29, 2018 •
edited by gnprice
Loading

@armaanahluwalia reported:

I'm seeing some very distracting and weird behaviour is observed while scrolling the unreads screen on 20.0.103. The title bars position seems to be moving around.
Link to video

This is a upstream issue.

Read more at https://chat.zulip.org/#narrow/stream/48-mobile/topic/Jitter.20on.20Scroll
@borisyankov
Copy link
Contributor

borisyankov commented Nov 29, 2018 •
edited by gnprice
Loading

The upstream issue PR is here:
facebook/react-native#22025
[EDIT by @gnprice: and upstream issue is facebook/react-native#20956 .]

This affects our unread screen UnreadCards, all users screen and user picker screen (that use the UserList component)

@gnprice gnprice added the upstream: RN Issues related to an issue in React Native label Dec 5, 2018
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jan 22, 2019
@borisyankov
No sticky headers in Unread
cfd516c 
Fixes: zulip#3286 and zulip#3176

Related but not ready to merge:
facebook/react-native#22025
borisyankov added a commit to borisyankov/zulip-mobile that referenced this issue Jan 22, 2019
@borisyankov
No sticky headers in Unread tab
5d7d4d3 
Fixes: zulip#3286 and zulip#3176

Related fix upstream but not ready to merge:
facebook/react-native#22025

A planed minor redesign (discussed with Rishi) to make the Unread
tabs less flashy and 'circus-colors-like' requires us to remove
the stickiness from the headers.

Even though though the design is still WIP, it makes sense to use
this change as a fix to an issue that was already reported multiple
times.

This makes the UnreadCards SectionList have normal, non-sticky
headers. We have to set `stickySectionHeadersEnabled` explicitly
to `false` as the defaults differ for iOS (true) and Android (false)
@borisyankov borisyankov mentioned this issue Jan 22, 2019
Closed
@gnprice
Copy link
Member

gnprice commented Jun 6, 2019

Fixed upstream in facebook/react-native@e4fd9babe, which landed in v0.59. So this should be resolved when we complete #3399 .

@gnprice gnprice added the blocked on other work To come back to after another related PR, or some other task. label Jun 6, 2019
@gnprice gnprice removed the blocked on other work To come back to after another related PR, or some other task. label Jul 26, 2019
@gnprice
Copy link
Member

gnprice commented Jul 26, 2019

And in fact with #3399 complete, this is now fixed! I just went and scrolled a ways through the list of users on czo (from "people" icon -> "Search" button), and the heading stayed firmly in place.

@gnprice gnprice closed this as completed Jul 26, 2019
@gnprice gnprice changed the title home screen: Jitter on Scroll. Jittering headings on scroll through unreads or users Jul 26, 2019
@gnprice gnprice changed the title Jittering headings on scroll through unreads or users Headings jitter on scroll through unreads or users list Jul 26, 2019
This was referenced Jul 26, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream: RN Issues related to an issue in React Native
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gnprice @borisyankov @jainkuniya