-
-
Notifications
You must be signed in to change notification settings - Fork 666
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This implementation has some problems. * Group Notification doesn't get cancelled when its children are. It will appear as an empty notification if all notification within a group are cancelled and will be required to be manually removed. * This will only happen in case of multiple groups, I have managed to cancel all notification if there are only group notifications remaining as active notifications. * It would be nice to have more information in notification payload to remove notification, the implementation currently performs a linear search for every message to be removed. Consider using a better approach.
- Loading branch information
1 parent
a91fdf4
commit 9de656f
Showing
1 changed file
with
36 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters