Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade all packages #89

Merged
merged 3 commits into from
May 11, 2023
Merged

deps: Upgrade all packages #89

merged 3 commits into from
May 11, 2023

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented May 10, 2023

deps: Upgrade package:checks, returning to published releases

There's now a new published version, so we can switch to that.

This effectively reverts e2d592d / #50.


deps: Upgrade packages to latest

Done with flutter pub upgrade --major-versions.

This updates two constraints in our pubspec.yaml:
https://pub.dev/packages/device_info_plus/changelog
https://pub.dev/packages/share_plus/changelog

The breaking changes that caused the major-version bumps are the
same in both packages, and only mean dropping support for old
versions of iOS, Android, and the Android Gradle Plugin.
These don't affect us.


I also directly pushed a few minutes ago a couple of dependency-related commits:
2ba4e71 lint: Directly ignore use_build_context_synchronously, where needed
5a59640 deps: Upgrade Flutter to latest main, 3.11.0-1.0.pre.56; upgrade some packages as required

In practice we run with more or less the latest Flutter SDK, because we don't currently have a way to pin it (#15). So it'd been bugging me for a little while that we have those lint failures causing noise and that I hadn't taken care of it. If we had CI running (#60), then those would have been a P0 issue, which in practice means we would have just fixed them immediately.

gnprice added 3 commits May 11, 2023 10:11
There's now a new published version, so we can switch to that.

This effectively reverts e2d592d / zulip#50.
Done with `flutter pub upgrade --major-versions`.

This updates two constraints in our pubspec.yaml:
  https://pub.dev/packages/device_info_plus/changelog
  https://pub.dev/packages/share_plus/changelog

The breaking changes that caused the major-version bumps are the
same in both packages, and only mean dropping support for old
versions of iOS, Android, and the Android Gradle Plugin.
These don't affect us.
@chrisbobbe
Copy link
Collaborator

Thanks, LGTM! Merging.

@chrisbobbe chrisbobbe merged commit 99dd6a7 into zulip:main May 11, 2023
@gnprice gnprice deleted the pr-deps branch May 12, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants