Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/check: pigeon runs old/cached version of Pigeon after Pigeon dependency is upgraded #622

Open
chrisbobbe opened this issue Apr 6, 2024 · 1 comment
Open

tools/check: pigeon runs old/cached version of Pigeon after Pigeon dependency is upgraded #622

chrisbobbe opened this issue Apr 6, 2024 · 1 comment
Labels
a-tools Our own development tooling, scripts, and infrastructure upstream Would benefit from work in Flutter or another upstream
Milestone
M6: Post-launch

Comments

@chrisbobbe
Copy link
Collaborator

Part of #621 was to upgrade Pigeon, from 17.2.0 to 18.0.0. After I did that, tools/check pigeon --all-files on my machine was running the old Pigeon, while in CI the newer Pigeon was running, as we want it to, and flagging the need to update generated files. I found a workaround: #621 (comment) but it would be nice not to require a manual step.

Can we make it so when we change the version of the Pigeon dependency, the next run of tools/check pigeon --all-files uses the updated version?
@chrisbobbe chrisbobbe added the a-tools Our own development tooling, scripts, and infrastructure label Apr 6, 2024
@chrisbobbe chrisbobbe mentioned this issue Apr 6, 2024
Merged
@gnprice gnprice added this to the Post-launch milestone May 9, 2024
@chrisbobbe chrisbobbe mentioned this issue May 29, 2024
Merged
gnprice added a commit to gnprice/zulip-flutter that referenced this issue May 30, 2024
@gnprice
deps: Upgrade pigeon to 18.0.1
803d41f 
Done with:
  $ flutter pub upgrade pigeon
  $ dart run pigeon
  $ tools/check --all-files --fix pigeon

The `dart run pigeon` step just ends up printing the command's
CLI help... but first it causes the `pigeon` package's CLI binary
to get rebuilt.  So it serves as a workaround for zulip#622.
@gnprice
Copy link
Member

gnprice commented May 30, 2024

To make the workaround explicit in this thread: it's that after an upgrade affecting package:pigeon, and before running tools/check pigeon, one runs dart run pigeon.

That just prints the pigeon CLI's help message… but first it causes the pigeon CLI binary itself to get rebuilt with the new package.

@gnprice gnprice added the upstream Would benefit from work in Flutter or another upstream label Nov 23, 2024
@gnprice gnprice mentioned this issue Nov 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-tools Our own development tooling, scripts, and infrastructure upstream Would benefit from work in Flutter or another upstream
Projects
Flutter app
Status: No status
Milestone
M6: Post-launch
Development

No branches or pull requests
2 participants
@gnprice @chrisbobbe