Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build broken because latest Flutter needs new intl #575

Closed
gnprice opened this issue Mar 20, 2024 · 0 comments · Fixed by #567
Closed

Build broken because latest Flutter needs new intl #575

gnprice opened this issue Mar 20, 2024 · 0 comments · Fixed by #567
Labels
a-tools Our own development tooling, scripts, and infrastructure
Milestone
M2: Beta 2, Sprin...

Comments

@gnprice
Copy link
Member

gnprice commented Mar 20, 2024

This will be fixed by #567 after that's revised and merged.

Until then, CI runs are failing with an error like this:

  Note: intl is pinned to version 0.19.0 by flutter_localizations
    from the flutter SDK.
  See https://dart.dev/go/sdk-version-pinning for details.

  Because zulip depends on flutter_localizations from sdk which
    depends on intl 0.19.0, intl 0.19.0 is required.
  So, because zulip depends on intl ^0.18.0, version solving failed.

  You can try the following suggestion to make the pubspec resolve:
  * Try upgrading your constraint on intl: flutter pub add intl:^0.19.0

The root cause here is:

For the moment until this broken build is fixed, the workaround is to run tools/check locally with a version of Flutter that's at least a few days old. In particular, the minimum version specified in pubspec.yaml should always work.
@gnprice gnprice added the a-tools Our own development tooling, scripts, and infrastructure label Mar 20, 2024
@gnprice gnprice added this to the Beta 2 milestone Mar 20, 2024
This was referenced Mar 20, 2024
Merged
Merged
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Mar 21, 2024
@chrisbobbe
deps: Upgrade intl constraint, from ^0.18.0 to ^0.19.0
a08b32a 
No potentially breaking changes identified in the changelog:
  https://github.com/dart-lang/i18n/blob/main/pkgs/intl/CHANGELOG.md#0190

This addresses the following error:

  Note: intl is pinned to version 0.19.0 by flutter_localizations
    from the flutter SDK.
  See https://dart.dev/go/sdk-version-pinning for details.

  Because zulip depends on flutter_localizations from sdk which
    depends on intl 0.19.0, intl 0.19.0 is required.
  So, because zulip depends on intl ^0.18.0, version solving failed.

  You can try the following suggestion to make the pubspec resolve:
  * Try upgrading your constraint on intl:
    flutter pub add intl:^0.19.0

And upgrade the minimum Flutter version too, since the `intl` change
breaks things if you have an older Flutter version. The Flutter bump
comes with a small tweak to respond to an API deprecation. The bump
also conveniently ensures that we have flutter/flutter@01fc13d9f, a
nice upstream improvement from our contributor VatsalBhesaniya.

Fixes: zulip#575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-tools Our own development tooling, scripts, and infrastructure
Projects
Flutter app
Status: Done
Milestone
M2: Beta 2, Spring 2024
Development

Successfully merging a pull request may close this issue.

deps: Upgrade intl constraint, from ^0.18.0 to ^0.19.0 chrisbobbe/zulip-flutter
1 participant
@gnprice