Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record Flutter commit ID as well as version number #1118

Closed
gnprice opened this issue Dec 9, 2024 · 0 comments · Fixed by #1117
Closed

Record Flutter commit ID as well as version number #1118

gnprice opened this issue Dec 9, 2024 · 0 comments · Fixed by #1117
Assignees
Labels
a-tools Our own development tooling, scripts, and infrastructure
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Dec 9, 2024

This issue can be seen as a much-scoped-down version of pinning the Flutter version:

That issue has stalled because the solutions to it tend to involve inserting themselves into the day-to-day development workflow — after all, they need to control what version of Flutter gets used — and none of the known solutions have felt totally satisfactory to me. Also because, in practice, our existing workflow without actual pinning generally works just fine.

There is one aspect that's bugged me a few times so far in practice, though, and which doesn't call for changing anything in the day-to-day workflow so it should be much easier to resolve: I'd like to know the Git commit ID for the Flutter version that we were using at a specific point in the repo's history. Specifically in practice, I want to know what Flutter commit ID was used for a given published (beta) release.

I already make a practice of building each release with the exact minimum version recorded in pubspec.yaml, in order to make it reproducible. So this information is there in principle, encoded in that version number. But from those Flutter version numbers (3.27.0-1.0.pre.518, in our pubspec.yaml in main at the moment) it's somewhat annoying to identify the actual Git commit ID (01590aa27ac4d3a904d25ae4c6b792f933a3da6f in that example, i.e. flutter/flutter@01590aa).

We can solve this by just having the commit ID also in pubspec.yaml, e.g. in a comment on the same line. Then tools/upgrade can maintain the comment. Ideally, we can even have a check in tools/check that verifies it's accurate.

@gnprice gnprice added the a-tools Our own development tooling, scripts, and infrastructure label Dec 9, 2024
@gnprice gnprice added this to the M5: Launch milestone Dec 9, 2024
@gnprice gnprice self-assigned this Dec 9, 2024
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 9, 2024
Fixes zulip#1118, or anyway the main part of it.

Upcoming commits will add a suite in tools/check that validates
this information, in case this line gets updated manually rather
than using this script.
@gnprice gnprice closed this as completed in 7b4312a Dec 9, 2024
shivanshsharma13 pushed a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
Fixes zulip#1118, or anyway the main part of it.

Upcoming commits will add a suite in tools/check that validates
this information, in case this line gets updated manually rather
than using this script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-tools Our own development tooling, scripts, and infrastructure
Projects
Status: Done
1 participant