-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spellchecker Improvements #322
Conversation
Ideally spellchecker should detect the language, but on macOS, it fails to auto-detect the lanugage user is typing in that's why we need to mention it explicitly. We set this language with the help of the default language of the server.
Rewrote the Spellchecker class so that we can have better control over the context menu and spellchecker.
Settings are initialized only when user clicks on General/Server/Network section settings In case, user doesn't visit these section, those values set to be null automatically. This fix makes sure the default settings are correctly set to either true or false.
@cedricium can you cross check if everything works fine? Specially these things -
|
@akashnimare will check it out later today and let you know how everything goes. |
@akashnimare looks great! On Windows, works just like you said - despite the server/user language, spellcheck will pick up on the typed language and make suggestions that way (don't have Linux so not able to test that specifically). The same goes for Mac too. Turning on and off spellcheck was easy enough. Just one note: it appears that spellcheck depends on the user's language preference, not the server's language. If the server had a language set to Spanish and the user had English, spellcheck would not recognize Spanish words. Switching the user's language would make spellcheck work as intended. |
@cedricium thanks for testing it out. From server language I meant the user's language preference. |
I think spellchecker should depends on user's language preference only. That way they can control spellchecker. Normal users don't have any control over org language settings thus they can't choose spellchecker language. |
This PR adds couple of functionalities in Spellchecker -
Deutsch
as the server language then the spellchecker will check spelling against the same.This PR also fixes a bug which was caused by not setting the default settings properly.