Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to hide the tray icon #104

Closed
timabbott opened this issue Feb 2, 2017 · 6 comments
Closed

Add an option to hide the tray icon #104

timabbott opened this issue Feb 2, 2017 · 6 comments

Comments

@timabbott
Copy link
Member

I've gotten feedback from a few users that they would appreciate the ability to disable the Mac OS menu bar item for Zulip to keep it uncluttered.

@akashnimare akashnimare changed the title Add option to not show an item in the Mac OS menu bar Add an option to hide the Menu bar Feb 3, 2017
@akashnimare akashnimare changed the title Add an option to hide the Menu bar Add an option to hide the tray icon Feb 4, 2017
geeeeeeeeek pushed a commit to geeeeeeeeek/zulip-electron that referenced this issue Mar 4, 2017
@geeeeeeeeek
Copy link
Collaborator

I've sent a PR to toggle the tray icon.

screen shot 2017-03-05 at 12 53 01 am

However, in the future, I think we should have a centralized Preference pane to collect all these settings. So that users won't bother to repeat these actions as they restart the app.

@timabbott
Copy link
Member Author

Yeah, agreed, a centralized preference pane is a good model.

@geeeeeeeeek have you checked out the old/legacy desktop app that was written in QT/webkit available from https://chat.zulip.org/apps/? It had a few menu items, which may be useful context for you in thinking about this.

@geeeeeeeeek
Copy link
Collaborator

geeeeeeeeek commented Mar 5, 2017

Didn't know there were a legacy app. I will look into that. But we are going to do the Preferences pane, there better be a ux design.

@geeeeeeeeek
Copy link
Collaborator

@timabbott Electron does not provide a way to integrate a native Preference pane. We need to write a local web app (or web page) to do that. Maybe in another PR. I would suggest adding the option to the menu for now.

screen shot 2017-03-05 at 4 14 16 pm

akashnimare added a commit that referenced this issue Mar 6, 2017
…ide-tray-icon

#104 Add a menu item to toggle the tray icon.
@akashnimare
Copy link
Member

I would suggest adding the option to the menu for now.

Make sense. Merged #122

@akashnimare
Copy link
Member

Moving this discussion to https://github.com/zulip/zulip-electron/issues/123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants