Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function requirements #280

Closed
wisenut2009 opened this issue Jan 17, 2021 · 14 comments
Closed

Function requirements #280

wisenut2009 opened this issue Jan 17, 2021 · 14 comments
Labels
✅enhancement 🌐i18n Localization/Internationalization 💪needs contribution This issue can not be fixed by me, contribution is welcome ui
Milestone

Comments

@wisenut2009
Copy link

wisenut2009 commented Jan 17, 2021

  1. Highlighting only the current line, not the current paragraph, with the options "Word Wrap" and "Highlight Current Line" checked.
  2. Adding an "Always on Top" button on the toolbar.
  3. An option "Sticky Window Position".

Thanks!

@zufuliu
Copy link
Owner

zufuliu commented Jan 17, 2021

First one: duplicate of issue #110.
Second one: Settings -> Windows Options -> Always On Top
Third One: "Sticky Window Position" is default behavior, Notepad2 starts with window location and size stored in Notepad2.ini.

@wisenut2009
Copy link
Author

  1. A button on the toolbar may be more convenient.
  2. Notepad2 starts with the position it exited last time. Can it start with a fixed position?

@zufuliu
Copy link
Owner

zufuliu commented Jan 17, 2021

@blackcrack
Copy link

blackcrack commented Jan 17, 2021

remember with the last position
" //place/filename.extension 246x503x234"
" D:/place/filename.extension 256x523x244"
is maybe not a bad idea.. like it, but then is need a "n2.position.log" or something..

@wisenut2009
Copy link
Author

  1. use command line option '/p', https://github.com/zufuliu/notepad2/wiki/Command-Line-Switches#command-line-switches

It works, but is a little inconvenient.

@wisenut2009
Copy link
Author

wisenut2009 commented Jan 17, 2021

First one: duplicate of issue #110.
Second one: Settings -> Windows Options -> Always On Top
Third One: "Sticky Window Position" is default behavior, Notepad2 starts with window location and size stored in Notepad2.ini.

Does it mean function requirement 1 will never be implemented?

@zufuliu
Copy link
Owner

zufuliu commented Jan 18, 2021

First one: duplicate of issue #110.
Second one: Settings -> Windows Options -> Always On Top
Third One: "Sticky Window Position" is default behavior, Notepad2 starts with window location and size stored in Notepad2.ini.

Does it mean function requirement 1 will never be implemented?

No, it will be implemented in the future as I also need it, there is already a checked option "Highlight subline".

@wisenut2009
Copy link
Author

First one: duplicate of issue #110.
Second one: Settings -> Windows Options -> Always On Top
Third One: "Sticky Window Position" is default behavior, Notepad2 starts with window location and size stored in Notepad2.ini.

Does it mean function requirement 1 will never be implemented?

No, it will be implemented in the future as I also need it, there is already a checked option "Highlight subline".

Thanks. I'm looking forward to it!

@zufuliu zufuliu added ✅enhancement 💪needs contribution This issue can not be fixed by me, contribution is welcome labels Jan 20, 2021
@zufuliu
Copy link
Owner

zufuliu commented Feb 27, 2021

"Always on Top" button can be added after someone contribute a toolbar image (I will not work on this myself, also please check licenses for images found on the Internet).

@Shakil-Shahadat
Copy link

I need the 'Always on Top' button too.

Anyway, this icon from 'Bootstrap Icons' can be used https://icons.getbootstrap.com/icons/pin-angle/. It has MIT License.

@zufuliu zufuliu added the 🌐i18n Localization/Internationalization label Apr 9, 2021
@zufuliu zufuliu added this to the v4.21.05 milestone Apr 10, 2021
@zufuliu
Copy link
Owner

zufuliu commented Apr 24, 2021

Hi @Shakil-Shahadat thanks for the image, I download it from https://github.com/twbs/icons/releases, added it into toolbar in fe6768a, following is the new toolbar:
always-on-top

As you can see, it's theme (or style) is not compatible with current toolbar image. You can follow these steps to make the new toolbar image:

  1. Install Python 3.7 or later.
  2. Install latest Pillow
  3. Install inkscape
  4. Open pin-angle.svg with inkscape, then click File -> Export PNG Images to export whole page as 16x16 png, see following screenshot
    export-svg-as-png
  5. Use old Toobar.bmp, edit https://github.com/zufuliu/notepad2/blob/master/tools/ImageTool.py#L234, uncomment concat_horizontal(['../res/Toolbar.bmp', 'images/pin-angle-16x.png'], 'Toolbar.bmp'), then run ImageTool.py to build the toolbar image. For current updated Toobar.bmp, you can call split_horizontal() to split it into 16x16 small images.

Notepad2 supports external toolbar images, you can uncomment BitmapDefault in Notepad2.ini, set it to the path of new toobar image you built and test it.

[Toolbar Images]
;BitmapDefault=Toolbar.bmp
;BitmapHot=ToolbarHot.bmp
;BitmapDisabled=ToolbarDisabled.bmp

@Shakil-Shahadat
Copy link

Thank you so much. I did some testing too. I'll let you know the progress.

@zufuliu
Copy link
Owner

zufuliu commented Apr 24, 2021

"Sticky Window Position" menu (needs translation) is added by d15282f, when it's enabled, "Clear Position History" will be disabled, please test latest builds and check whether it works as expected.

@wisenut2009
Copy link
Author

"Sticky Window Position" menu (needs translation) is added by d15282f, when it's enabled, "Clear Position History" will be disabled, please test latest builds and check whether it works as expected.

Thank you very much.

@zufuliu zufuliu closed this as completed May 13, 2021
RaiKoHoff pushed a commit to RaiKoHoff/notepad2 that referenced this issue Jul 19, 2021
RaiKoHoff pushed a commit to RaiKoHoff/notepad2 that referenced this issue Jul 19, 2021
@zufuliu zufuliu added the ui label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅enhancement 🌐i18n Localization/Internationalization 💪needs contribution This issue can not be fixed by me, contribution is welcome ui
Projects
None yet
Development

No branches or pull requests

4 participants