-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make editor work with current version of the game #29
Conversation
Wow! Thanks so much for digging and looking into this! I'll be sure to get this deployed and maybe add some CI so I can stop doing manual deploys 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions before I can merge this in, but great work!
I'll get it tested and merged after these are corrected
I've also been messing around with it and found a couple minor changes that need to be made to handle the new LosslessNumber type. Throughout a day of testing and using it, I'm feeling even more confident in this fix. I'm in the process of adding all of the new cards/relics to |
Resolved all feedback and also made a small fix to handle the fact that the value of |
Also moved the changes I was talking about for |
Since `upgrades` can be a `LosslessValue` or a number, the ternary condition needs to handle both.
feature/gh-pages-init
After doing some troubleshooting, it looks like the main issue that was causing it to crash was that the seed for the save was too big for a js float, so it was being rounded.
For example:
was being rounded to
This would cause the game to crash when the map gen for the rounded seed would conflict with the map position info in the save file.
Adding
lossless-json
solves this issue pretty easily. I did some very simple testing and the tool seems to be working again with this fix.