Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network extended ASCII codes and '%'? #184

Closed
zturtleman opened this issue Mar 3, 2014 · 2 comments
Closed

Network extended ASCII codes and '%'? #184

zturtleman opened this issue Mar 3, 2014 · 2 comments

Comments

@zturtleman
Copy link
Member

In msg.c, ioq3 filters out characters > 127 and '%' (replaced with '.'). World of Padman allows char != 0xFF and != '%'. I think all values would be needed for UTF-8.

The comments say they're filtered out because "because old clients don't like them".

Should '%' be replaced with "%%" to avoid format issues? Would msg.c need to be aware of UTF-8 for this?

@zturtleman zturtleman added this to the Spearmint 1.0 PLUS EDITION milestone Mar 3, 2014
@zturtleman
Copy link
Member Author

iostvef removes the filters.

@zturtleman
Copy link
Member Author

I made string value more than 127 networkable. '%' is still not, and is not required for UTF-8 (aside from '%' itself). And no, cannot cover it to %% as that only works if it's the format string which is not suppose to happen.

UTF-8 doesn't use 0xFF, I didn't think about removing it until re-reading this issue. Though I do not know why World of Padman removes it.

@zturtleman zturtleman modified the milestones: Spearmint 0.1, Spearmint 1.0 Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant