Fix highlighting of multiline aliases #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
danielshahaf
force-pushed
the
aliases-multiline-exempt-empty-command-check-v1
branch
from
1081952 to
cf1d58e
Compare
|
Rebased due to b454b59. |
The fix is to exempt such aliases from the empty commands sanity check.
danielshahaf
force-pushed
the
aliases-multiline-exempt-empty-command-check-v1
branch
from
cf1d58e to
ade4b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exempt such aliases from the empty commands sanity check.
Does anyone see a downside to making this change? The argument is basically that it's not z-sy-h's job to lint the user's dotfiles, but I wonder if there's a counter-argument that I'm overlooking.
Fixes #677, which knowingly regressed in 0.7.0 compared to 0.6.0..
This didn't require converting
';'back to$'\n'in alias expansions after all.@itchyny Please test/review.