Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logic to determine if a data set is a PDS & fixed non existent source data set bug #2448

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pujal0909
Copy link
Contributor

@pujal0909 pujal0909 commented Feb 26, 2025

What It Does

  1. Adjusted the logic for determining if a data set is a PDS to ensure that dsorgs of PO-E, PO-L, PO-U are handled correctly.
    pds: Some PDS operations may have unexpected behavior #2390
  2. When using the copy command with a non existent source data set, it displayed an unclear error. Now, the error is clear and user-friendly.
    copyPds: Misssing source PDS throws a non-user-friendly error #2447

How to Test

For the non existent source data set fix:

  1. Use the copy command with a source data set that does not exist.
  2. With the current functionality, it displays this error: "Cannot read properties of undefined (reading 'dsorg')"
  3. Now, it displays a more clear error: "Data set copied aborted. The source data set was not found."

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
@pujal0909 pujal0909 changed the title Updated logic to determine if a data set is a PDS & fixed missing source PDS bug Updated logic to determine if a data set is a PDS & fixed non existent source data set bug Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (c0d2da2) to head (611f229).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2448      +/-   ##
==========================================
- Coverage   91.49%   91.49%   -0.01%     
==========================================
  Files         641      641              
  Lines       18416    18415       -1     
  Branches     4000     3998       -2     
==========================================
- Hits        16850    16849       -1     
  Misses       1563     1563              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool stuff! 🥳

happy for tormally review once it's ready 😋

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
@pujal0909 pujal0909 marked this pull request as ready for review February 26, 2025 20:53
@pujal0909 pujal0909 requested a review from zFernand0 February 26, 2025 20:53
Copy link

📅 Suggested merge-by date: 3/12/2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

2 participants