-
Notifications
You must be signed in to change notification settings - Fork 6
allows users to alter default all tree filter value; fixes #147 #242
Conversation
Signed-off-by: Rajpreetgill <73036580+Rajpreetgill@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality works perfectly! 👍 I have added suggestions for a small tweak in the description (i.e. the text that appears as a description of the input box in Settings (UI)).
package.json
Outdated
"zowe.cics.allPrograms.recordCountIncrement": { | ||
"type": "number", | ||
"default": 500, | ||
"description": "Default filter criteria for all Programs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to change the description to "Default record count increment for 'All Programs'"
package.json
Outdated
"zowe.cics.allTransactions.recordCountIncrement": { | ||
"type": "number", | ||
"default": 500, | ||
"description": "Default filter criteria for all Transactions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to change the description to "Default record count increment for 'All Transactions'"
package.json
Outdated
"zowe.cics.allLocalFiles.recordCountIncrement": { | ||
"type": "number", | ||
"default": 500, | ||
"description": "Default filter criteria for all Local Files", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to change the description to "Default record count increment for 'All Local Files'"
package.json
Outdated
"zowe.cics.allTasks.recordCountIncrement": { | ||
"type": "number", | ||
"default": 500, | ||
"description": "Default filter criteria for all Tasks", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to change the description to "Default record count increment for 'All Tasks'"
Signed-off-by: Rajpreetgill <73036580+Rajpreetgill@users.noreply.github.com>
Signed-off-by: Rajpreetgill 73036580+Rajpreetgill@users.noreply.github.com