Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

allows users to alter default all tree filter value; fixes #147 #242

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

Rajpreetgill
Copy link
Collaborator

Signed-off-by: Rajpreetgill <73036580+Rajpreetgill@users.noreply.github.com>
@Rajpreetgill Rajpreetgill requested a review from JeffinSiby June 16, 2022 16:04
Copy link
Collaborator

@JeffinSiby JeffinSiby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works perfectly! 👍 I have added suggestions for a small tweak in the description (i.e. the text that appears as a description of the input box in Settings (UI)).

package.json Outdated
"zowe.cics.allPrograms.recordCountIncrement": {
"type": "number",
"default": 500,
"description": "Default filter criteria for all Programs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to change the description to "Default record count increment for 'All Programs'"

package.json Outdated
"zowe.cics.allTransactions.recordCountIncrement": {
"type": "number",
"default": 500,
"description": "Default filter criteria for all Transactions",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to change the description to "Default record count increment for 'All Transactions'"

package.json Outdated
"zowe.cics.allLocalFiles.recordCountIncrement": {
"type": "number",
"default": 500,
"description": "Default filter criteria for all Local Files",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to change the description to "Default record count increment for 'All Local Files'"

package.json Outdated
"zowe.cics.allTasks.recordCountIncrement": {
"type": "number",
"default": 500,
"description": "Default filter criteria for all Tasks",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to change the description to "Default record count increment for 'All Tasks'"

Signed-off-by: Rajpreetgill <73036580+Rajpreetgill@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants