This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Handle new APIML unique cookie identifier #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master zowe/imperative#996 +/- ##
==========================================
+ Coverage 89.73% 89.76% +0.03%
==========================================
Files 211 211
Lines 11471 11533 +62
Branches 2554 2584 +30
==========================================
+ Hits 10293 10353 +60
- Misses 1178 1180 +2
☔ View full report in Codecov by Sentry. |
4 tasks
zFernand0
requested review from
t1m0thyj,
gejohnston,
awharn,
traeok,
KevinLoesch1 and
ATorrise
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
… and viceversa Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
…le config-secure call Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
…ady have a token Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
awharn
suggested changes
Jul 3, 2023
packages/imperative/src/config/cmd/auto-init/handlers/BaseAutoInitHandler.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
t1m0thyj
reviewed
Jul 5, 2023
gejohnston
approved these changes
Jul 6, 2023
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
t1m0thyj
reviewed
Jul 10, 2023
Comment on lines
+199
to
+208
| // Force the use of token value, in case user and/or password are also provided. | ||
| if (params.arguments.tokenValue != null && | ||
| (params.arguments.user != null || params.arguments.password != null)) { | ||
| params.arguments.user = undefined; | ||
| params.arguments.password = undefined; | ||
| } | ||
|
|
||
| params.arguments.tokenType = this.mDefaultTokenType; | ||
| if (params.arguments.tokenType == null) { | ||
| params.arguments.tokenType = this.mDefaultTokenType; | ||
| } |
There was a problem hiding this comment.
Should we handle removing certificates from the session as well? I guess this may not be a concern, if tokens have a higher priority than certificates when both are present 😅
awharn
approved these changes
Jul 10, 2023
|
will test with ZE before moving it to ready for review again 😋 |
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
…lient Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
…n as possible Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
…we had the token already Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
ATorrise
approved these changes
Jul 20, 2023
KevinLoesch1
approved these changes
Jul 20, 2023
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
add ImperativeExpect.toMatchRegExpmethodlogoutoperations from failing due to not having a token availableautoStorefor dynamic APIML token typesallowedlogoutoperation to remove token type and/or token value when either is not specified in the config filegetProfileNameFromPathto help with nested token authenticationconfig securecommandconsole.logto inform which profile credentials are being prompted forauto-initfrom performing twologinoperations on a single commandHow to Test
I recommend to combine this PR with the CLI counterpart:
Please see the above PR for testing instructions.
Review Checklist
I certify that I have:
Additional Comments
Opened issues as a result of this PR:
zowe config securedoes notautoStoreproperties it prompts for zowe-cli#1866