Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Fixing prompting in ConnectionPropsForSessCfg #436

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

katelynienaber
Copy link
Contributor

This is a small fix.

The issue is that in function ConnectionPropsForSessCfg, if the username/password were missing, the user would be prompted for these values even if a token was present.

Now user/pass are only prompted if the token is missing.

… value is empty

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_212) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #436 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files         157      157           
  Lines        7634     7635    +1     
  Branches     1383     1384    +1     
=======================================
+ Hits         6251     6252    +1     
  Misses       1379     1379           
  Partials        4        4           
Impacted Files Coverage Δ
...ages/rest/src/session/ConnectionPropsForSessCfg.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9358746...cccdc15. Read the comment docs.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.
I've had a similar problem in the CLI, but I get that this is only targeted for the getValuesBack section.
I'll investigate a little more and open an issue

@katelynienaber katelynienaber requested a review from a user August 21, 2020 08:50
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants